Linux clock framework development
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: "Erikas Bitovtas" <xerikasxx@gmail.com>,
	"Vikash Garodia" <vikash.garodia@oss.qualcomm.com>,
	"Dikshita Agarwal" <dikshita.agarwal@oss.qualcomm.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>,
	"Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
Date: Wed, 20 May 2026 09:32:46 +0100	[thread overview]
Message-ID: <608dc53d-17a8-4230-9ebb-48a94bf03675@kernel.org> (raw)
In-Reply-To: <20260519-msm8939-venus-rfc-v8-2-542ec7557ebc@gmail.com>

On 19/05/2026 16:10, Erikas Bitovtas wrote:
> Allow Venus core GDSCs to have their control passed to hardware, so they
> can be powered on by Venus firmware.
> 
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>   drivers/clk/qcom/gcc-msm8939.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 45193b3d714b..243d31a32e92 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
> 
>   static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>   	.halt_reg = 0x4c02c,
> +	.halt_check = BRANCH_HALT_SKIP,
>   	.clkr = {
>   		.enable_reg = 0x4c02c,
>   		.enable_mask = BIT(0),
> @@ -3681,6 +3682,7 @@ static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
> 
>   static struct clk_branch gcc_venus0_core1_vcodec0_clk = {
>   	.halt_reg = 0x4c034,
> +	.halt_check = BRANCH_HALT_SKIP,
>   	.clkr = {
>   		.enable_reg = 0x4c034,
>   		.enable_mask = BIT(0),
> @@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = {
>   	.pd = {
>   		.name = "venus_core0",
>   	},
> +	.flags = HW_CTRL_TRIGGER,
>   	.pwrsts = PWRSTS_OFF_ON,
>   };
> 
> @@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = {
>   	.pd = {
>   		.name = "venus_core1",
>   	},
> +	.flags = HW_CTRL_TRIGGER,
>   	.pwrsts = PWRSTS_OFF_ON,
>   };
> 
> 
> --
> 2.54.0
> 

@Tanyia

Can you confirm this change please ?

---
bod

  reply	other threads:[~2026-05-20  8:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 1/9] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
2026-05-20  8:32   ` Bryan O'Donoghue [this message]
2026-05-20  8:41     ` Bryan O'Donoghue
2026-05-21  9:29     ` Taniya Das
2026-05-22 10:48       ` Erikas Bitovtas
2026-05-25  5:51         ` Taniya Das
2026-05-25  9:56           ` Erikas Bitovtas
2026-05-25 10:38             ` Taniya Das
2026-05-25 22:50             ` Bryan O'Donoghue
2026-06-01  8:29               ` Taniya Das
2026-06-01  8:48                 ` Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 3/9] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism Erikas Bitovtas
2026-05-20  8:38   ` Bryan O'Donoghue
2026-05-19 15:10 ` [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new " Erikas Bitovtas
2026-05-20  8:39   ` Bryan O'Donoghue
2026-05-20 12:45   ` Dmitry Baryshkov
2026-05-19 15:10 ` [PATCH v8 6/9] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 7/9] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 8/9] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=608dc53d-17a8-4230-9ebb-48a94bf03675@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=git@apitzsch.eu \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=taniya.das@oss.qualcomm.com \
    --cc=vikash.garodia@oss.qualcomm.com \
    --cc=xerikasxx@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox