linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sergej Sawazki <sergej@taudac.com>,
	sboyd@codeaurora.org, mturquette@baylibre.com,
	linux@armlinux.org.uk
Cc: rabeeh@solid-run.com, linux-clk@vger.kernel.org
Subject: Re: [RESEND PATCH 3/3] clk: si5351: Add a debug message for PLL reset
Date: Thu, 14 Sep 2017 08:47:40 +0200	[thread overview]
Message-ID: <60cbc3ee-541c-10cd-5fb3-810607252109@gmail.com> (raw)
In-Reply-To: <1504346246-4730-4-git-send-email-sergej@taudac.com>

On 02.09.2017 11:57, Sergej Sawazki wrote:
> Print a debug message when resetting a PLL. It is useful to figure out
> what PLL is resetted and when.

I am fine with the debug message but please squash it into the patch
adding _si5351_clkout_reset_pll.

Sebastian

> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Sergej Sawazki <sergej@taudac.com>
> ---
>  drivers/clk/clk-si5351.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> index aa8d8d9..7a122c7 100644
> --- a/drivers/clk/clk-si5351.c
> +++ b/drivers/clk/clk-si5351.c
> @@ -917,6 +917,10 @@ void _si5351_clkout_reset_pll(struct si5351_driver_data *drvdata, int num)
>  	si5351_reg_write(drvdata, SI5351_PLL_RESET,
>  			 (val & SI5351_CLK_PLL_SELECT) ? SI5351_PLL_RESET_B :
>  			 SI5351_PLL_RESET_A);
> +
> +	dev_dbg(&drvdata->client->dev, "%s - %s: pll = %d\n",
> +		__func__, clk_hw_get_name(&drvdata->clkout[num].hw),
> +		(val & SI5351_CLK_PLL_SELECT) ? 1 : 0);
>  }
>  
>  static int si5351_clkout_prepare(struct clk_hw *hw)
> 

      reply	other threads:[~2017-09-14  6:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02  9:57 [RESEND PATCH 0/3] clk: si5351: PLL reset fixes Sergej Sawazki
2017-09-02  9:57 ` [RESEND PATCH 1/3] clk: si5351: Apply PLL soft reset before enabling the outputs Sergej Sawazki
2017-09-14  6:44   ` Sebastian Hesselbarth
2017-09-02  9:57 ` [RESEND PATCH 2/3] clk: si5351: Add DT property to enable PLL reset Sergej Sawazki
2017-09-14  6:46   ` Sebastian Hesselbarth
2017-09-02  9:57 ` [RESEND PATCH 3/3] clk: si5351: Add a debug message for " Sergej Sawazki
2017-09-14  6:47   ` Sebastian Hesselbarth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60cbc3ee-541c-10cd-5fb3-810607252109@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=rabeeh@solid-run.com \
    --cc=sboyd@codeaurora.org \
    --cc=sergej@taudac.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).