public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Artur Weber <aweber.kernel@gmail.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Sam Protsenko <semen.protsenko@linaro.org>
Subject: Re: [PATCH v2] clk: samsung: Don't register clkdev lookup for the fixed rate clocks
Date: Thu, 18 Jul 2024 14:20:13 +0200	[thread overview]
Message-ID: <6227c1fb-d769-462a-b79b-abcc15d3db8e@gmail.com> (raw)
In-Reply-To: <20240510065901.535124-1-m.szyprowski@samsung.com>

On 10.05.2024 08:59, Marek Szyprowski wrote:
> Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
> clkdev entries") revealed that clock lookup is registered for all fixed
> clocks. The mentioned commit added a check if the registered name is not
> too long. This fails for some clocks registered for Exynos542x SoCs family.
> This lookup is a left-over from early common clock framework days, not
> really needed nowadays, so remove it to avoid further issues.

This commit causes a warning to appear during startup on Exynos 4x12:

 > [    0.000000] exynos4_clk_register_finpll: failed to lookup parent clock xusbxti, assuming fin_pll clock frequency is 24MHz
 > [    0.000000] Exynos4x12 clocks: sclk_apll = 400000000, sclk_mpll = 800000000
 >                	sclk_epll = 96000000, sclk_vpll = 108000000, arm_clk = 800000000

The warning seems to come from exynos4_clk_register_finpll in
drivers/clk/samsung/clk-exynos4.c, where clk_get fails with error code -2.

Best regards
Artur

  parent reply	other threads:[~2024-07-18 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240510065909eucas1p20067042a45b26e0a58110ff439dcc1b8@eucas1p2.samsung.com>
2024-05-10  6:59 ` [PATCH v2] clk: samsung: Don't register clkdev lookup for the fixed rate clocks Marek Szyprowski
2024-05-14 21:12   ` Stephen Boyd
2024-07-18 12:20   ` Artur Weber [this message]
2024-07-22  6:26     ` Krzysztof Kozlowski
2024-07-22  6:34       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6227c1fb-d769-462a-b79b-abcc15d3db8e@gmail.com \
    --to=aweber.kernel@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=semen.protsenko@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox