From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-clk <linux-clk@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Simon Horman <horms+renesas@verge.net.au>,
Stephen Boyd <sboyd@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: clk/Renesas-MSTP: Delete an error message for a failed memory allocation
Date: Fri, 16 Sep 2016 01:55:08 +0300 [thread overview]
Message-ID: <64106728.50RHrbMaf7@avalon> (raw)
In-Reply-To: <bd139d45-f7c1-ac79-6b38-93b1eb1f3e9a@users.sourceforge.net>
On Thursday 15 Sep 2016 22:17:41 SF Markus Elfring wrote:
> >>> Omit an extra message for a memory allocation failure in this function.
> >>>
> >>> Link:
> >>> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refact
> >>> or_Strings-WSang_0.pdf
> >>>
> >>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> >>
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > There are two other memory allocation failures printed by drivers in the
> > same directory that, you'll get my ack
>
> Does this kind of feedback express a general acceptance for the deletion
> of similar error messages?
No, it's my opinion only.
> > if you extend this patch to remove the three messages in one go.
>
> Does this wish influence the handling of suggested changes for the source
> file "drivers/clk/renesas/clk-mstp.c" anyhow?
> https://patchwork.kernel.org/patch/9332363/
Yes, please submit a new version of this patch that removes all the memory
allocation error messages from drivers/clk/renesas/ in one go.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-09-15 22:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <566ABCD9.1060404@users.sourceforge.net>
2016-09-14 19:56 ` [PATCH 0/4] clk/Renesas-MSTP: Fine-tuning for two function implementations SF Markus Elfring
2016-09-14 20:00 ` [PATCH 1/4] clk/Renesas-MSTP: Use kmalloc_array() in cpg_mstp_clocks_init() SF Markus Elfring
2016-09-15 19:11 ` Geert Uytterhoeven
2016-09-16 23:13 ` Stephen Boyd
2016-09-14 20:01 ` [PATCH 2/4] clk/Renesas-MSTP: Delete an error message for a failed memory allocation SF Markus Elfring
2016-09-15 19:07 ` Geert Uytterhoeven
2016-09-15 19:13 ` Laurent Pinchart
2016-09-15 19:41 ` Wolfram Sang
2016-09-15 20:17 ` SF Markus Elfring
2016-09-15 22:55 ` Laurent Pinchart [this message]
2016-09-16 5:21 ` SF Markus Elfring
2017-09-25 8:34 ` [PATCH] clk/Renesas: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-09-25 10:02 ` Geert Uytterhoeven
2016-09-14 20:03 ` [PATCH 3/4] clk/Renesas-MSTP: Less function calls in cpg_mstp_clocks_init() after error detection SF Markus Elfring
2016-09-15 19:11 ` Geert Uytterhoeven
2016-09-15 20:40 ` SF Markus Elfring
2016-09-15 20:48 ` Geert Uytterhoeven
2016-09-16 5:32 ` SF Markus Elfring
2016-09-14 20:04 ` [PATCH 4/4] clk/Renesas-MSTP: Rename jump labels in cpg_mstp_attach_dev() SF Markus Elfring
2016-09-15 19:18 ` Geert Uytterhoeven
2016-09-16 6:00 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64106728.50RHrbMaf7@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=elfring@users.sourceforge.net \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).