From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: SF Markus Elfring Cc: Geert Uytterhoeven , linux-clk , Geert Uytterhoeven , Michael Turquette , Simon Horman , Stephen Boyd , Ulf Hansson , LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall , Wolfram Sang Subject: Re: clk/Renesas-MSTP: Delete an error message for a failed memory allocation Date: Fri, 16 Sep 2016 01:55:08 +0300 Message-ID: <64106728.50RHrbMaf7@avalon> In-Reply-To: References: <566ABCD9.1060404@users.sourceforge.net> <2927869.3rNkSDiBcX@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: On Thursday 15 Sep 2016 22:17:41 SF Markus Elfring wrote: > >>> Omit an extra message for a memory allocation failure in this function. > >>> > >>> Link: > >>> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refact > >>> or_Strings-WSang_0.pdf > >>> > >>> Signed-off-by: Markus Elfring > >> > >> Reviewed-by: Geert Uytterhoeven > > > > There are two other memory allocation failures printed by drivers in the > > same directory that, you'll get my ack > > Does this kind of feedback express a general acceptance for the deletion > of similar error messages? No, it's my opinion only. > > if you extend this patch to remove the three messages in one go. > > Does this wish influence the handling of suggested changes for the source > file "drivers/clk/renesas/clk-mstp.c" anyhow? > https://patchwork.kernel.org/patch/9332363/ Yes, please submit a new version of this patch that removes all the memory allocation error messages from drivers/clk/renesas/ in one go. -- Regards, Laurent Pinchart