From: Heiko Stuebner <heiko@sntech.de>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
Lin Huang <hl@rock-chips.com>
Subject: Re: [PATCH] clk: rockchip: don't return NULL when failing to register ddrclk branch
Date: Fri, 14 Oct 2016 19:06:00 +0200 [thread overview]
Message-ID: <6436195.q1mHK715BP@phil> (raw)
In-Reply-To: <1476275501-2653-1-git-send-email-shawn.lin@rock-chips.com>
Am Mittwoch, 12. Oktober 2016, 20:31:41 CEST schrieb Shawn Lin:
> rockchip_clk_register_ddrclk should not return NULL when faling
> to call clk_register, otherwise rockchip_clk_register_branches
> prints "unknown clock type". The acutal case is that it's a known
> clock type but we fail to regiser it, which may makes user confuse
> the reason of failure. And the pr_err here is pointless as
> rockchip_clk_register_branches will also print the similar message.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
thanks for catching this ... applied to a clk-fixes branch for 4.9
prev parent reply other threads:[~2016-10-14 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:31 [PATCH] clk: rockchip: don't return NULL when failing to register ddrclk branch Shawn Lin
2016-10-14 17:06 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6436195.q1mHK715BP@phil \
--to=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox