From: Taniya Das <quic_tdas@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Melody Olvera <quic_molvera@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Trilok Soni <quic_tsoni@quicinc.com>,
"Satya Durga Srinivasu Prabhala --cc=linux-arm-msm @ vger .
kernel . org" <quic_satyap@quicinc.com>,
<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings for SM8750
Date: Wed, 6 Nov 2024 23:44:41 +0530 [thread overview]
Message-ID: <6486448c-15b3-4c46-8104-e5c8c1b5ec2e@quicinc.com> (raw)
In-Reply-To: <l7bs5xhoddlwggdd2ufc5lc2d33zkm2ewguwnd4t3gste2gjak@4qmcvkututzm>
On 10/22/2024 11:46 AM, Krzysztof Kozlowski wrote:
> On Mon, Oct 21, 2024 at 04:03:53PM -0700, Melody Olvera wrote:
>> From: Taniya Das <quic_tdas@quicinc.com>
>>
>> Add bindings and update documentation for clock rpmh driver on SM8750
>> SoCs.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> This applies to all your patches.
>
I will remove the extra "bindings" in the next patch and also cleanup
where ever required.
> There is already CXO clock, so why pad is needed? All of these clocks
> come via some pad, right? Commit msg could explain here this. Otherwise
> it just duplicates the diff.
>
Yes, I will fix the CXO clock and remove the newly added pad clock in
the next patch.
> Best regards,
> Krzysztof
>
--
Thanks & Regards,
Taniya Das.
next prev parent reply other threads:[~2024-11-06 18:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 23:03 [PATCH 0/7] clks: qcom: Introduce clks for SM8750 Melody Olvera
2024-10-21 23:03 ` [PATCH 1/7] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings " Melody Olvera
2024-10-22 6:16 ` Krzysztof Kozlowski
2024-11-06 18:14 ` Taniya Das [this message]
2024-10-21 23:03 ` [PATCH 2/7] clk: qcom: rpmh: Add support for SM8750 rpmh clocks Melody Olvera
2024-10-22 8:47 ` Bryan O'Donoghue
2024-11-06 18:14 ` Taniya Das
2024-10-23 3:40 ` Bjorn Andersson
2024-11-06 18:14 ` Taniya Das
2024-10-21 23:03 ` [PATCH 3/7] clk: qcom: clk-alpha-pll: Add support for controlling Taycan PLLs Melody Olvera
2024-10-23 3:48 ` Bjorn Andersson
2024-11-06 18:15 ` Taniya Das
2024-10-21 23:03 ` [PATCH 4/7] dt-bindings: clock: qcom: Add SM8750 GCC clock controller Melody Olvera
2024-10-22 6:18 ` Krzysztof Kozlowski
2024-11-06 18:14 ` Taniya Das
2024-10-23 3:52 ` Bjorn Andersson
2024-10-21 23:03 ` [PATCH 5/7] clk: qcom: Add support for GCC clock controller on SM8750 Melody Olvera
2024-10-23 4:00 ` Bjorn Andersson
2024-11-06 18:15 ` Taniya Das
2024-10-21 23:03 ` [PATCH 6/7] dt-bindings: clock: qcom: Document the SM8750 TCSR Clock Controller Melody Olvera
2024-10-23 8:15 ` Krzysztof Kozlowski
2024-10-21 23:03 ` [PATCH 7/7] clk: qcom: Add TCSR clock driver for SM8750 Melody Olvera
2024-10-23 3:30 ` [PATCH 0/7] clks: qcom: Introduce clks " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6486448c-15b3-4c46-8104-e5c8c1b5ec2e@quicinc.com \
--to=quic_tdas@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox