Re: [PATCH v5 08/26] drm: sun4i: de3: add YUV support to the DE3 mixer

Ryan Walklin
2025-02-15T01:19:21Z

On Sun, 20 Oct 2024, at 3:14 AM, Dmitry Baryshkov wrote:
> On Sun, Sep 29, 2024 at 10:04:40PM +1300, Ryan Walklin wrote:

>> diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h
>> index c48cbc1aceb80..ffafc29b3a0c3 100644
>> --- a/drivers/gpu/drm/sun4i/sunxi_engine.h
>> +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h

>> @@ -151,6 +153,9 @@ struct sunxi_engine {
>>
>> int id;
>>
>> + u32 format;
>> + enum drm_color_encoding encoding;
>
> Should these be a part of the state instead of being a part of the
> sunxi_engine?

Sure, would you suggest in sun8i_mixer_cfg?

Regards,

Ryan