Re: [PATCH v5 19/26] dt-bindings: allwinner: add H616 DE33 bus binding

Chris Morgan
2025-02-12T17:27:30Z

On Sun, Sep 29, 2024 at 10:04:51PM +1300, Ryan Walklin wrote:
> The Allwinner H616 and variants have a new display engine revision
> (DE33).
>
> Add a display engine bus binding for the DE33.
>
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> ---
> Changelog v1..v2:
> - Correct DE2 bus enum to reflect fallback devices accurately.
>
> Changelog v2..v3:
> - Separate content into three patches for three separate subsystems
> ---
> .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml
> index 9845a187bdf65..ea7ee89158c61 100644
> --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml
> +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml
> @@ -24,7 +24,9 @@ properties:
> oneOf:
> - const: allwinner,sun50i-a64-de2
> - items:
> - - const: allwinner,sun50i-h6-de3
> + - enum:
> + - allwinner,sun50i-h6-de3
> + - allwinner,sun50i-h616-de33
> - const: allwinner,sun50i-a64-de2
>
> reg:
> --
> 2.46.1
>

Because the h616 uses additional reg values, we need to change
reg:
maxItems: 1

To
reg:
minItems: 1
maxItems: 3

Thank you,
Chris