Re: [PATCH v5 08/26] drm: sun4i: de3: add YUV support to the DE3 mixer

Ryan Walklin
2025-02-15T03:49:02Z

On Sat, 15 Feb 2025, at 2:18 PM, Ryan Walklin wrote:
> On Sun, 20 Oct 2024, at 3:14 AM, Dmitry Baryshkov wrote:
>> On Sun, Sep 29, 2024 at 10:04:40PM +1300, Ryan Walklin wrote:
>
>>> diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h
>>> index c48cbc1aceb80..ffafc29b3a0c3 100644
>>> --- a/drivers/gpu/drm/sun4i/sunxi_engine.h
>>> +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h
>
>>> @@ -151,6 +153,9 @@ struct sunxi_engine {
>>>
>>> int id;
>>>
>>> + u32 format;
>>> + enum drm_color_encoding encoding;
>>
>> Should these be a part of the state instead of being a part of the
>> sunxi_engine?
>
> Sure, would you suggest in sun8i_mixer_cfg?

Hmm, on second thought the mixer config is a const struct, presumably because it is defined per engine variant in sun8i_mixer.c. Is there a better place to store state like this? Otherwise the engine may not be the worst choice, as the color format and encoding apply to the entire pipeline, at least in the case of a single display?

Regards,

Ryan