Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

Stephen Boyd
2018-10-11T07:19:33Z

Quoting Vinod (2018-10-07 20:51:44)
> On 07-10-18, 19:38, Stephen Boyd wrote:
> > Quoting Vinod (2018-10-02 23:21:03)
> > > Hi Stephen,
> > >
> > > Thanks for the comments,
> > >
> > > On 01-10-18, 10:19, Stephen Boyd wrote:
> > > > Quoting Vinod Koul (2018-09-21 11:59:36)
> > > > > From: Shefali Jain <shefjain@codeaurora.org>
> > > > >
> > > > > Add the clocks supported in global clock controller which clock the
> > > > > peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks
> > > > > to the clock framework for the clients to be able to request for them.
> > > > >
> > > > > Signed-off-by: Shefali Jain <shefjain@codeaurora.org>
> > > > > Signed-off-by: Taniya Das <tdas@codeaurora.org>
> > > > > Co-developed-by: Taniya Das <tdas@codeaurora.org>
> > > > > Signed-off-by: Anu Ramanathan <anur@codeaurora.org>
> > > > > [rebase and tidyup for upstream]
> > > >
> > > > Who did the tidying?
> > >
> > > both of us :)
> >
> > OK, please add the username of both people per the kernel sign off
> > standards.
> >
> > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> Sorry not sure I understand, Bjorn and me did cleanup and we signed-off
> per process, did I miss something?

I mean doing something like:

[bjorn.andersson@linaro.org: Clean and tidy]
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
[vkoul@kernel.org: Clean and tidy even more]
Signed-off-by: Vinod Koul <vkoul@kernel.org>

Would be the kernel standard for maintainer tags.

>
> > > > > + [GCC_USB_HS_PHY_CFG_AHB_CLK] = &gcc_usb_hs_phy_cfg_ahb_clk.clkr,
> > > > > + [GCC_USB_HS_SYSTEM_CLK] = &gcc_usb_hs_system_clk.clkr,
> > > > > + [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr,
> > > > > + [GP1_CLK_SRC] = &gp1_clk_src.clkr,
> > > >
> > > > Why are some of these missing GCC_ prefix?
> > >
> > > will add..
> >
> > Thanks!
>
> Btw Taniya also commented on this, do you want this as GCC_ or as per hw
> documentation?
>

I don't care. Either way is fine with me.