Linux clock framework development
 help / color / mirror / Atom feed
From: Denzeel Oliva <wachiturroxd150@gmail.com>
To: linux-samsung-soc@vger.kernel.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] clk: samsung: exynos990: Fix PERIS gate clock parents
Date: Sat, 13 Jun 2026 08:06:40 -0500	[thread overview]
Message-ID: <6a2d55e2.bf38ae28.2d8f62.4755@mx.google.com> (raw)

On Sat, Jun 13, 2026, Sashiko AI wrote:
> Does reordering the mout_peris_clk_peris_gic_p array break the hardware
> register mapping?
>
> In the Exynos clock framework, the indices of the PNAME array correspond
> directly to the hardware multiplexer register bit values...

The reorder does not break the mapping — it corrects it. The original
upstream PNAME order was a porting bug that inverted the parents.

The downstream Exynos9830 source confirms the hardware register encoding
(drivers/soc/samsung/cal-if/exynos9830/cmucal-node.c:1093-1096):

  enum clk_id cmucal_mux_clk_peris_gic_parents[] = {
      MUX_CLKCMU_PERIS_BUS_USER,   // index 0 → mux value 0
      OSCCLK_PERIS,                 // index 1 → mux value 1
  };

So hardware mux value 0 selects MUX_CLKCMU_PERIS_BUS_USER (upstream:
mout_peris_bus_user), not oscclk. The original upstream had these
swapped, which would cause clk_set_parent() to write the wrong mux
register value.

This patch fixes that inversion.

             reply	other threads:[~2026-06-13 13:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13 13:06 Denzeel Oliva [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-13 12:36 [PATCH v3 0/3] clk: samsung: exynos990: Fix PERIS gate clock parents and add TMU_SUB Denzeel Oliva
2026-06-13 12:36 ` [PATCH v3 3/3] clk: samsung: exynos990: Fix PERIS gate clock parents Denzeel Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a2d55e2.bf38ae28.2d8f62.4755@mx.google.com \
    --to=wachiturroxd150@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox