From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3CD7C43334 for ; Thu, 30 Jun 2022 13:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbiF3NfA (ORCPT ); Thu, 30 Jun 2022 09:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230203AbiF3Ne7 (ORCPT ); Thu, 30 Jun 2022 09:34:59 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7B9F2871E for ; Thu, 30 Jun 2022 06:34:54 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id o23so23107898ljg.13 for ; Thu, 30 Jun 2022 06:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Cs0qaK6bESbp2DFdkuLn3sAtIu+NiQn2SQSD9VgJFpI=; b=wx6eI1NSAdoeV0j8dNWEEiceAeuA8jMZOLSZ+CwRcN2U0KxSgnqdufycWwKZJ2S7dR Lq+VQPVPv0+hubv4MABp6tREvsCcovpEHpyj7wHsN46wENGYEJTPwTzT1xpu6cVwR75i 2QLItxQwRVXHzcv482DASalbOYhZxPKVsTdmEhD5KVxi/m1l/9XHNdYEHPW+OzVPjXLI FAn84pmM/a0Sa9WtInGvRbRsx11n4qKdymbdJt+Qn3cuJ48NYrPZ9knozJT4ZZNMCC3x MD6Tihx6dM7axGRn9NLNP8zM2iEHiMCMDg45U5ELuM1tq/2XwQlmYQgMPUPyj4I9jcgg kCKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Cs0qaK6bESbp2DFdkuLn3sAtIu+NiQn2SQSD9VgJFpI=; b=DovIRl1knZcucFoR2TNC8YlhfVXEPV3HKEDcvxrnEOhfOK/KNN4+50o2SqjHdL7o7T XPKZELrCBD0O1yGR+7KiWNzXfLSnqKp7nePU+lAD7iwfvuhGDMDVgNRSXpxk0pYGJMh2 tuIzUkULEWXo5CvOOg99EvX2wHgjhBVc0cFhS3P6wrZWj9q7AMd9uVCuOKnlC6uiTMmT QDh9UxrWz6X5yFojCBwDNVVhJeZV/4ydNzMACxXOzWw5qnaFmcYFG75wA7dlM5a37AWn c/xDGn+3oSZeJcqjEm185wn/VphzZ2SH3SECGGjAem2nrMrv9nAYdfPoIQYBDdJhNB5K 7DKg== X-Gm-Message-State: AJIora8DL8Jn77skaL/CpHkPPEQAWmOEPQw5TdMO8uA6FwIiHoiVq5fJ jRHLZUUVn92Xqssct9lssbjI1/1YtmmhzQ== X-Google-Smtp-Source: AGRyM1tb35ZQuDsFSQ4qqgwkA6YUl7UROEuTommfMO7KDPyAcEPquNXQrTpl+3AcOW8skHiYe6j0/w== X-Received: by 2002:a05:651c:11d0:b0:25a:978e:4892 with SMTP id z16-20020a05651c11d000b0025a978e4892mr5411337ljo.517.1656596092401; Thu, 30 Jun 2022 06:34:52 -0700 (PDT) Received: from [192.168.1.102] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id z9-20020a0565120c0900b004793240041esm3101067lfu.277.2022.06.30.06.34.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 06:34:51 -0700 (PDT) Message-ID: <6c6dddb7-a2d1-e93c-7448-6edb8ae3e665@linaro.org> Date: Thu, 30 Jun 2022 16:34:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 5/7] clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces Content-Language: en-US To: Vinod Koul Cc: Bjorn Andersson , Andy Gross , Stephen Boyd , Michael Turquette , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org References: <20220630081742.2554006-1-vladimir.zapolskiy@linaro.org> <20220630081825.2554069-1-vladimir.zapolskiy@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Vinod, On 6/30/22 15:14, Vinod Koul wrote: > On 30-06-22, 11:18, Vladimir Zapolskiy wrote: >> Add controls for Lucid EVO PLL configuration and export control functions >> to clock controller drivers. > > This sound fine but maybe add why we are adding this (to be used in > dispcc driver)... motivation helps :) > sure, and please note, that it's used by camcc as well, basically it's a reason why this change is found in the series :) > Other than this nit, lgtm: > > Reviewed-by: Vinod Koul > Thanks you for review! -- Best wishes, Vladimir