From: Ricardo Pardini <ricardo@pardini.net>
To: Heiko Stuebner <heiko@sntech.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Daniele Briguglio <hello@superkali.me>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Diederik de Haas <diederik@cknow-tech.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: Re: [PATCH] clk: rockchip: rk3588: don't disable unused I2S MCLK output gates
Date: Thu, 23 Jul 2026 07:34:05 +0200 [thread overview]
Message-ID: <6cc68287-ee87-4db6-8f40-531ec2d92fb2@pardini.net> (raw)
In-Reply-To: <178267399833.3089434.5140309637329023610.b4-ty@sntech.de>
On 28/06/2026 21:13, Heiko Stuebner wrote:
>
> On Wed, 24 Jun 2026 14:39:14 +0200, Daniele Briguglio wrote:
>> No in-tree board references these gates yet. Boards drive the codec
>> MCLK through the parent I2S*_8CH_MCLKOUT, and now that the gates are
>> managed clocks, clk_disable_unused() turns them off at boot. On a board
>> that relied on firmware leaving the output enabled, that cuts the MCLK
>> and analog audio stops working.
>>
>> Mark the four gates CLK_IGNORE_UNUSED so an unreferenced gate keeps the
>> state firmware left. A board that wants the kernel to own the gate can
>> reference I2S*_8CH_MCLKOUT_TO_IO from DT instead.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] clk: rockchip: rk3588: don't disable unused I2S MCLK output gates
> commit: 946352b2f88fd2378f0341312e47dff1e8dc2fac
>
Hi Heiko, Stephen,
sorry to pester, but do you think it's possible to include this in the
next -fixes for Linus?
It's been in mmind v7.2-clk/fixes for a few weeks now, but I haven't
seen it in -rc4.
Thanks,
Ricardo
next prev parent reply other threads:[~2026-07-23 5:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:39 [PATCH] clk: rockchip: rk3588: don't disable unused I2S MCLK output gates Daniele Briguglio
2026-06-24 13:42 ` Sebastian Reichel
2026-06-27 7:30 ` Ricardo Pardini
2026-06-28 19:13 ` Heiko Stuebner
2026-07-23 5:34 ` Ricardo Pardini [this message]
2026-08-05 16:53 ` Igor Paunovic
2026-08-05 17:00 ` Chen-Yu Tsai
2026-08-05 23:09 ` Brian Masney
2026-08-06 3:37 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc68287-ee87-4db6-8f40-531ec2d92fb2@pardini.net \
--to=ricardo@pardini.net \
--cc=diederik@cknow-tech.com \
--cc=heiko@sntech.de \
--cc=hello@superkali.me \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).