From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FD163B9D9F for ; Wed, 29 Apr 2026 09:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777453656; cv=none; b=bC7qY9OIGd5393GavaILTSbZw7LihgM7fh1MxIb1X/7TQUeWujrLiiozhYSmsNtSKbaVOJoAqqKFstQalXERk5YWyR2MmDf0TNP7v5Nh5Cn87n5NRkn80M72rRbzUHTXc90JXw2kmcsa83vQUMysdZUml2SUHT3ZPNJCKeX4lJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777453656; c=relaxed/simple; bh=AwZuUXPk4/WpmF+r8jDpB7wrDuVU3zFwiYudmOuTakQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BSBbup4XWb/2xd9NYVmNu5D2SaX6373qt0rLNXA0Vp0AwecTdGpC3VQVCKpB+MYmf5uNSGuaB30eIigsYoRv9vOcmeznk9KemFWKLiZTLpZ2DkF3orqwYshrQv9S4K85ftX0EhvA6zE0CKJ4ebRm/7HSRAxoGd7E7zsld8E+Mtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WzlnfwAr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WzlnfwAr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so162766155e9.0 for ; Wed, 29 Apr 2026 02:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777453653; x=1778058453; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8Lj5tmUBXJFmzYH2N7Dd27gLNCll+S51FdGFIIdlW1Y=; b=WzlnfwAr4DJID5MtMtZ5nD/hIInr+BJPMOmbnxGKYJdc5oZo19tk5YD9fLAkzZx6XQ t3oQIb8ONLqCn/clp6+dSaUcXmlYA3KCj10APjyZq7ZodhQmXFSqwnaLOmUGNbyCleTm 06KP2V5WK1ba+Rto9wLX78pIU7NRQJ04Q0CVYPJrBu62F7rfNGcphlKxmE4TuIEXtKCL cvgXoI3me+BsJRE8jRB9xrFiYKz/sWrAL/oJepsxfZK1x95WzrxSfx7SCcR3wacUGxKy CrMfpKo5lqE5pUI2WOG5Vws/QVrqM3u92g9nBypyXlW7YbdWoFLZ72kYqIFcDXyRtY+7 r+6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777453653; x=1778058453; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Lj5tmUBXJFmzYH2N7Dd27gLNCll+S51FdGFIIdlW1Y=; b=Z2n0VQyJBFKxEChp43Y6y3cz7mu7Q5A88c+hvBxB6wMNvATnxmPPJ/34VGb1flHP3T tYHKD9lo8Ttmq2H4Nw/2iPZBD5aO5IqSFeehyya0wYXYEe41wGajmvyf5BuPFsQm0+G+ 4iUj4zH0iLtUBR72bFplHFLi3fVVTZnVOvJ0+rkzVyU+VoUDfRK9dD27irjxESz1xzm2 LU8Ivyw6QcDiKT05v44i/YT2XvFONjVswB6m2Wgq2dw/FPbUyJEDXSg/h+7Zbfpt0jbS FJq3ETvSzQl15sC3Pu7k6vQlx9JMFCe3UwyWT6znb7Z0yQMIBCBN+tWyLx60//VvjvKQ GgCQ== X-Forwarded-Encrypted: i=1; AFNElJ8H27zsrelAXfHPeoLsNCnVT3/RadAqV/Ml/EZhnSZFPFVG03rz9vB70Z7m0hlQI+Ud3Ob4vLKuucc=@vger.kernel.org X-Gm-Message-State: AOJu0YzUO6LBJQ9TCY57aU5R1edkmUMEzxjlNNUgFiZLz33CoDxEqnHf cWytb5b+adQ8jrB0IO0g89gzylBF60LbgFhHjK5bkB4RH2tqRxEOj1Oy7cD9qtlgcgs= X-Gm-Gg: AeBDievSL673q0HB9y6MkIdU5dVdKXdhLhfn0FJAA/tNgPH0ynVIve9Q01ibj/WXsup c/rT+FmHpxWN/2mo0tfiaBUvDS2+kOfYdoYFW7SlBBu0jne5hQ1QZ0Bj59ZSBmQjUzN5v1iJEDW 44CQW0PuVH2SNtfIHGPojfAVlRp4Rhf3xbzhpAysVlb1oD2W6Jk2fXz1+ocRXEYKdBtBIDKsNNl ERT4YNu2qcYwRdgyd9pQ3MC9+9TY0VedFAxXd/QaPAt2DnxCfrQ7Hyc4agerx7TkYINDqE7PXQi +HEHrVmJCMjFZMCbSJtYAj5+0RsUd3Y5t/zsb73TENEEisVbM9ZADQPnwFw3cVHHrAgbMsT9Xhj jiUjVc5ENNbI8k/n/iDc5BdHGOposvneCriPLN4IhWM7Wt6hDEnjn5eQRS/TImi0wbn/0tvWX1o yIU/jtsJ3knYXDNqRcPWgyDRykUrb8j2KQ+a6R4FRt8R4= X-Received: by 2002:a05:600c:2e55:b0:48a:7b55:12a6 with SMTP id 5b1f17b1804b1-48a7b55131amr28563845e9.0.1777453652729; Wed, 29 Apr 2026 02:07:32 -0700 (PDT) Received: from [10.11.12.108] ([79.115.63.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7c5d1a53sm40803645e9.14.2026.04.29.02.07.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 02:07:32 -0700 (PDT) Message-ID: <6dcb5348-e973-494d-adf1-7fa2dc5655f2@linaro.org> Date: Wed, 29 Apr 2026 12:07:28 +0300 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] mailbox: exynos: Add support for Exynos850 mailbox To: Alexey Klimov Cc: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Sam Protsenko , Michael Turquette , Stephen Boyd , Rob Herring , Conor Dooley , Jassi Brar , Krzysztof Kozlowski , Peter Griffin , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260402-exynos850-ap2apm-mailbox-v2-0-ca5ffdff99d4@linaro.org> <20260402-exynos850-ap2apm-mailbox-v2-2-ca5ffdff99d4@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/28/26 11:26 PM, Alexey Klimov wrote: > On Wed Apr 8, 2026 at 2:08 PM BST, Alexey Klimov wrote: > > [...] > >> On Thu Apr 2, 2026 at 9:42 AM BST, Tudor Ambarus wrote: >>>> static int exynos_mbox_send_data(struct mbox_chan *chan, void *data) >>>> @@ -57,7 +104,8 @@ static int exynos_mbox_send_data(struct mbox_chan *chan, void *data) >>>> return -EINVAL; >>>> } >>>> >>>> - writel(BIT(msg->chan_id), exynos_mbox->regs + EXYNOS_MBOX_INTGR1); >>>> + writel(BIT(msg->chan_id) << exynos_mbox->data->irq_doorbell_shift, >>>> + exynos_mbox->regs + exynos_mbox->data->irq_doorbell_offset); >>> >>> Use FIELD_PREP from please. You will use a mask instead of >>> a shift. >>> >>> I would rename irq_doorbell_offset to intgr. It aligns with the register name >>> from the datasheet. You won't need to prepend _offset to the name, we already >>> see it's an offset when doing the writel(). >> >> Sure. Thanks. Let's use FIELD_PREP. > > + /* Ring the doorbell */ > + writel(BIT(msg->chan_id) << exynos_mbox->data->intgr_shift, > + exynos_mbox->regs + exynos_mbox->data->intgr); > > FIELD_PREP() wants a mask as a compile-time constant. Unless you want me to Indeed, I forgot, sorry. > add switch/case for different SoCs or I misunderstood something I don't see > how this is gonna fly. other option is to have a .ring_doorbell callback defined in the SoC data, and then you can use FIELD_PREP. But it increases boilerplate code just to ring a doorbell. I wouldn't go via switch/case. I think we'll have to live with the mask and shift. Cheers, ta