From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08BE727F731 for ; Tue, 15 Apr 2025 09:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744708403; cv=none; b=GuKU61DEuAoIyOUifSmXyw7kw+CXWvQ+qgkJBkRA2xB0d4F7jpwf7FFS45aPfyWxbOyYy/csxW1Hcv8bhFaQD+8+m82N5LVJJ7EmJno6UjgjSASt1i9G7zgAT558CvOFJ5j9IbdsCYpzcqowbwnqjSUbJIIeELtp61XBN7SNnUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744708403; c=relaxed/simple; bh=Y3cF4eZoT0Tuq6lyHi7dJ/kFBdodGF0lWp44qmkdgv4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fCcwrH18oNHFwFCPFO2VvZmTPDpFfhGD2VEM9JhMZLsOpLV1icSdLosjrFC6YVwgMO0z5Mx1RU4u5xKoWjO+nPgWpDJlRtcam4OHBHyO4V/aA0/2d4KxZvFEqzvGlNJwSbUOtbk6kKXTl2v+7nVEVZ9GJKE9i6pmDguxrIMY1Dg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Get02uRv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Get02uRv" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53F8tNDf005961 for ; Tue, 15 Apr 2025 09:13:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +rR/+ftTAIsUkZ0fyx0/CUkeHOOpZznIIF7t4NeJeNc=; b=Get02uRvEClbLNVW Za/NGMqD2SjwhAF1sQ+mUGp65SqHxDQ+/nEsap/p/jPrSq6ecxoLpky4Cz0LrCjh F75iploxuFy3ymU2u2C22tdJwydEt80jEY880WksKEO04ZKgtBI8Ss+IZ84pErPi bGu0ZcsDvYJbfUcEJZHWrE0+DgVc7xeL0Ri+7KHMuWRKTO6T+Ae3odONED1qhwh9 PbpckzaoYHB3rjVCjV74QlB66dqzewYhrXjLyy2I1WPoA2MO2yugxjk5FhYWgkQM h3hUD81z06d3r+POH6pRKqxlu2Mov4PJUfeirxp/SipoaRXkjc8D+JyW66JaZv5W 0p9Ing== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45ydvj7mwu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 15 Apr 2025 09:13:20 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c5af539464so127350585a.0 for ; Tue, 15 Apr 2025 02:13:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744708399; x=1745313199; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+rR/+ftTAIsUkZ0fyx0/CUkeHOOpZznIIF7t4NeJeNc=; b=QrQqAtyrCe/9QRz8H2N7ifnq2/3210YRs/eUJYDt9tMFZ6AJakOoIa1HMjg31dcTYa vyd/BBm8boyObgRK1yH4shBxr0YuHbMBBh87pbSUbMOolOdOA4O2creeqgbNNBdZDvZv 3rHQLqXiP5jmi/hO1jEZDPp+Y70ETyE7izpF6iV32mXHeRsZjQ5bHGv83QGxCHE+jSSr dCBf7pQrL30IIPLFs1erJS8GUuZRsz1ygicj9XRYfpe1CxSRdrb2xTfojz+cdTJxW34b F5KwT9mDknsqCR4G5v0b2KxK40Esyvvg0Mji2T+BsPjNNLrOS1BPH78E/W0QVzG8Zu26 aWRw== X-Forwarded-Encrypted: i=1; AJvYcCWrQvaHgPBCKjNOu1K7GWpm2zPy4zatzNtmtvVeVxxWRGmO1QztOQYf13kyJcmwSC92WvuGJWWJZGk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9sqpzMMXOzNURkQ2O3mIUwSTl9yY3t7YTotdPNWoANm2yx32c Z5SJ0VSye6Iw0Smia7WQvIjTkfeA5qVgn4qZvkqoZ49N2gAKA/RbRPJNlIZlzOBJXos1U8+xZwj elnLex2BPoMnlEKgWru/8VdIAkpzh+xmr2XSg8a/jgRBnQFY2cIElsC17D38= X-Gm-Gg: ASbGncuWqPRuxWjAalKc/HVdSTN9M5+rB93NGaJT6dCGqsM7Vlg2p8Y/N7//KyDu0qS VjeYaplppddqg6UZcbHIahvbkRewqq+Jzk4Xz71ihgxojUlr15HMJVdkUYLf9TjLp4t5/KvuDFX vF8V5PlLqOee9U1ah4cqdXJaM/lNdKp1oVUMufKfdFdy8OL3SMhJSNsMXv7RfpR9ddF6dt8jBbm npuUzNAhFlV/xfRpQabZZLgZ8a6IVI/hiyeLUquzf30ccsY5q1rMF7AAqY+ZjPVfwGpG75qP4+w /7P6YGrG0Y1Iraj5y41Uj2fDnc+yNNKudZo1wUXw4wa9kRwlTB6+glQvux9kZNGlZr8= X-Received: by 2002:a05:620a:450b:b0:7c0:a1ca:93cb with SMTP id af79cd13be357-7c7dd7355f2mr150176985a.1.1744708398827; Tue, 15 Apr 2025 02:13:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5b7ibStatFaNQd403wS1RPgFmV1TghCWOGZLKiMrn2UNIPOtfVqPrSYwuKnQ0CSbSEiFzWA== X-Received: by 2002:a05:620a:450b:b0:7c0:a1ca:93cb with SMTP id af79cd13be357-7c7dd7355f2mr150176085a.1.1744708398451; Tue, 15 Apr 2025 02:13:18 -0700 (PDT) Received: from [192.168.65.246] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f36f6491c4sm6271585a12.81.2025.04.15.02.13.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Apr 2025 02:13:17 -0700 (PDT) Message-ID: <702ba6b2-b84d-41e0-aedf-747535d6ab32@oss.qualcomm.com> Date: Tue, 15 Apr 2025 11:13:14 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sm6350: Add video clock controller To: Taniya Das , Konrad Dybcio , Jagadeesh Kona , Luca Weiss , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250324-sm6350-videocc-v2-0-cc22386433f4@fairphone.com> <20250324-sm6350-videocc-v2-4-cc22386433f4@fairphone.com> <1c09fee5-9626-4540-83fb-6d90db2ce595@oss.qualcomm.com> <9eb6dfd7-2716-4150-9392-98e26892d82d@quicinc.com> <69fba227-ed47-4004-9451-777ca19b687f@quicinc.com> <0db798bf-04b3-40b5-af90-7dda5b606727@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0db798bf-04b3-40b5-af90-7dda5b606727@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ZIrXmW7b c=1 sm=1 tr=0 ts=67fe2330 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=6H0WHjuAAAAA:8 a=KHwu0kPLBxgQqcPLut8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=TjNXssC_j7lpFel5tvFf:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: RJwaUnoac_LRmY9CstgKcMOMCnkHlB9H X-Proofpoint-ORIG-GUID: RJwaUnoac_LRmY9CstgKcMOMCnkHlB9H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-15_04,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504150063 On 4/15/25 6:05 AM, Taniya Das wrote: > > > On 4/12/2025 12:56 AM, Konrad Dybcio wrote: >> On 4/11/25 1:37 PM, Jagadeesh Kona wrote: >>> >>> >>> On 4/11/2025 2:42 PM, Konrad Dybcio wrote: >>>> On 4/11/25 9:15 AM, Jagadeesh Kona wrote: >>>>> >>>>> >>>>> On 4/1/2025 10:03 PM, Konrad Dybcio wrote: >>>>>> On 3/24/25 9:41 AM, Luca Weiss wrote: >>>>>>> Add a node for the videocc found on the SM6350 SoC. >>>>>>> >>>>>>> Signed-off-by: Luca Weiss >>>>>>> --- >>>>>>> arch/arm64/boot/dts/qcom/sm6350.dtsi | 14 ++++++++++++++ >>>>>>> 1 file changed, 14 insertions(+) >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi >>>>>>> index 42f9d16c2fa6da66a8bb524a33c2687a1e4b40e0..4498d6dfd61a7e30a050a8654d54dae2d06c220c 100644 >>>>>>> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi >>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi >>>>>>> @@ -1952,6 +1952,20 @@ usb_1_dwc3_ss_out: endpoint { >>>>>>> }; >>>>>>> }; >>>>>>> >>>>>>> + videocc: clock-controller@aaf0000 { >>>>>>> + compatible = "qcom,sm6350-videocc"; >>>>>>> + reg = <0x0 0x0aaf0000 0x0 0x10000>; >>>>>>> + clocks = <&gcc GCC_VIDEO_AHB_CLK>, >>>>>>> + <&rpmhcc RPMH_CXO_CLK>, >>>>>>> + <&sleep_clk>; >>>>>>> + clock-names = "iface", >>>>>>> + "bi_tcxo", >>>>>>> + "sleep_clk"; >>>>>>> + #clock-cells = <1>; >>>>>>> + #reset-cells = <1>; >>>>>>> + #power-domain-cells = <1>; >>>>>>> + }; >>>>>> >>>>>> You'll probably want to hook up some additional power domains here, see >>>>>> >>>>>> https://lore.kernel.org/linux-arm-msm/20250327-videocc-pll-multi-pd-voting-v3-0-895fafd62627@quicinc.com/ >>>>>> >>>>> >>>>> On SM6350, videocc doesn't need multiple power domains at HW level, it is only on CX rail which would be ON >>>>> when system is active, hence power-domains are not mandatory here. >>>> >>>> 6350 doesn't have either MMCX nor a split MX - shouldn't both normal >>>> CX and MX be in there? >>>> >>> >>> All clocks & GDSC's of SM6350 videocc are only on CX rail, so it requires only CX power domain. But when HLOS >>> is active, CX rail will be ON and operate at a level above retention, which is sufficient for videocc to operate. >>> Hence clock driver don't need to explicitly vote on CX rail. >>> >>> The same is not true for other rails like MMCX and Split MX(MXC), hence clock drivers had to explicitly vote on >>> those rails. >> >> I'm worried about MX being undervolted for higher OPPs >> > > From a videocc PoV there is no requirement of Mx on SM6350. The CX > levels would be taken care by Video SW driver from their defined OPP. Mx > at system level would be catered via the BW votes. So I'm specifically thinking about the videocc (and other) PLLs, which have defined vdd levels downstream - currently we're relying on random luck rather than ensuring each one of them has its requirements fulfilled Konrad