From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] arm64: dts: qcom: msm8996: add CBF device entry
Date: Thu, 12 Jan 2023 16:39:54 +0100 [thread overview]
Message-ID: <719bfea0-0aea-fbab-3ffa-3f6c330f16d2@linaro.org> (raw)
In-Reply-To: <fdd82d5f-d66b-b297-ed28-f44e9806e020@linaro.org>
On 12.01.2023 16:38, Dmitry Baryshkov wrote:
> On 12/01/2023 17:05, Konrad Dybcio wrote:
>>
>>
>> On 11.01.2023 20:57, Dmitry Baryshkov wrote:
>>> Add device tree node for the CBF clock.
>>>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>> index 37ebd8a3b2c8..e5a638b85ffc 100644
>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>> @@ -3558,6 +3558,13 @@ saw3: syscon@9a10000 {
>>> reg = <0x09a10000 0x1000>;
>>> };
>>> + cbf: clock-controller@9a11000 {
>>> + compatible = "qcom,msm8996-cbf";
>>> + reg = <0x09a11000 0x10000>;
>>> + clocks = <&rpmcc RPM_SMD_BB_CLK1>, <&apcs_glb>;
>> Shouldn't this be RPM_SMD_XO_A_CLK_SRC? I don't see BB_CLK
>> referenced *anywhere* downstream, other than being defined
>> in the 8996 GCC driver..
>
> Good question. On the schematics I have the CXO input is connected to the BBCLK1 PMIC pin.
I guess it's a question of how RPM resolves this internally.. I
think I was once told that you just ask RPM nicely to turn on
the clock and everything is handled for you from there on,
so perhaps we don't need to poke at BBCLK manually if it's only
used as XO parent?
Konrad
>
>>
>> Konrad
>>
>>> + #clock-cells = <0>;
>>> + };
>>> +
>>> intc: interrupt-controller@9bc0000 {
>>> compatible = "qcom,msm8996-gic-v3", "arm,gic-v3";
>>> #interrupt-cells = <3>;
>
next prev parent reply other threads:[~2023-01-12 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 19:57 [PATCH 0/5] clk: qcom: msm8996: add support for the CBF clock Dmitry Baryshkov
2023-01-11 19:57 ` [PATCH 1/5] dt-bindings: clock: qcom,msm8996-cbf: Describe the MSM8996 CBF clock controller Dmitry Baryshkov
2023-01-12 8:40 ` Krzysztof Kozlowski
2023-01-12 9:47 ` Dmitry Baryshkov
2023-01-12 11:46 ` Krzysztof Kozlowski
2023-01-11 19:57 ` [PATCH 2/5] clk: qcom: add msm8996 Core Bus Framework (CBF) support Dmitry Baryshkov
2023-01-12 14:58 ` Konrad Dybcio
2023-01-12 19:26 ` Dmitry Baryshkov
2023-01-11 19:57 ` [PATCH 3/5] clk: qcom: cbf-msm8996: scale CBF clock according to the CPUfreq Dmitry Baryshkov
2023-01-12 15:00 ` Konrad Dybcio
2023-01-12 15:29 ` Dmitry Baryshkov
2023-01-12 15:37 ` Konrad Dybcio
2023-01-11 19:57 ` [PATCH 4/5] arm64: dts: qcom: msm8996: add CBF device entry Dmitry Baryshkov
2023-01-12 15:05 ` Konrad Dybcio
2023-01-12 15:38 ` Dmitry Baryshkov
2023-01-12 15:39 ` Konrad Dybcio [this message]
2023-01-11 19:57 ` [PATCH 5/5] arm64: dts: qcom: msm8996: scale CBF clock according to the CPUfreq Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719bfea0-0aea-fbab-3ffa-3f6c330f16d2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox