From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38CB44C67F6 for ; Thu, 3 Sep 2026 15:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788448475; cv=none; b=HZzvPER0Roofd+i1dQREMyFy5yFL6vM1YUMIx91ebHWT8g0EQc56M30z1B7AjY5na8a5711fTf5agCivbOC1n5h8GaryQxTpjDiIXPtRuYK0oAoccRxouY1/vb9LpeiOLROPpu0e8jVexAGcu4v0ZALi17zo9piRV2ozGSPh7aY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788448475; c=relaxed/simple; bh=AiYQDdr1GA2GGgxtoSCbSmmY5cDjwiV95VNMSZnOgqY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ukVlfisvmw5T+PhHGJUrMpCXFHxV3t74aY7VKqqIDBQCwDj7mjLrU7lkS2B2ezNWxYRk28CNoynOGIXp+MZy1MZHYPt7Mvz/uKaMANVKaOlxWkovqe9kAZHBFdK8RMN7rQxzpv7WDTcQsZH2Na4ZHAffKIJNqHm+c/mMc85TaCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hLybQAxw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bwDacICr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hLybQAxw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bwDacICr" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683DAEWs4093519 for ; Thu, 3 Sep 2026 15:14:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J00Y5jbKG+LTIOozErGYVV5kDH4wOcI6n7Jz1ZNdUIc=; b=hLybQAxwHn+9hFwL fBStui1wKAaJMVUD6eb41AZTw02LAlzRN7xihyBI9X0HCwGRDS0PCWp5Ikuu85CK te2MVy3HFFaMRf81PRamfHht6gAs38VGRMVwP9/7lZICVAS6GCNgX2u7gRCbZORR 2YkBM6zXMnWRAtGYswNuzzJhrf5Vo/nuaTSfhlxs5ANXBehb7HeBhdUh1m37ognf 7/4AiH2a/aIoVgKLJbwvBe6qNQwmO9xfYTJlB5TNvCTNFAk2VrGTmGsD4qZ1bUij eEPORVT5CKagGKvlhIp9kcAwvotHq5RzYzyXFe018oxaCBJzskIuNJS5/DiUSew1 UHLHlg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf0gjtsqt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 15:14:32 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d94a158dc8so39944125ad.2 for ; Thu, 03 Sep 2026 08:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788448471; x=1789053271; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=J00Y5jbKG+LTIOozErGYVV5kDH4wOcI6n7Jz1ZNdUIc=; b=bwDacICrtKVadZR++rd/YFsPcWXv8O27Xr9LUgAu0fG3EXC+7ywE8hYxbi7Tqx0tJH 4SRXJS7TBTxqgA53osfFs8TIhVN0ks/oUmsUpJoHWZ9ZkttRyOk3PrFpzUVE4onaCKos RWn78hdzIRLsRiq/A8oF89HF1aAsmt35mtgKFeab6Wa4NrvLjr5Z0kkU+rObj4mnE4SA lZQgZV1TzBnaKOQMfQh22Mh1iP9B7mC3ANfCXojVtYGKVt+xKTbR57v9S19GcsPwey4P VQXwXGC7pjwCguxm2+anLhKpyO2Nle0/LCSj8yCbtIncGy1hgNktLydkY499sMrmJWiL UJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788448471; x=1789053271; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J00Y5jbKG+LTIOozErGYVV5kDH4wOcI6n7Jz1ZNdUIc=; b=CV93a0psc4hc5BMmH/MteWqLn+mzipqjV3qCVEq9by4KBFiVY7RlFDttzmFjoeZUq+ AswJBM0I6j1u6HLTP3oSxE0n1aQoCnjNLc15koVTkj1E0AEVgRGjXFB1v2jpHVVbek8J a4SRS/oPNHBmm8ChOsg7xRa5GoiVUHZ+xF11P546tcD6bLbWXBDeufLtghIzvvej76Qo WMxbOBSGaQzdbCitUNfI0eAVdqhhlLI8pUB7zaE8fRmjmlVjMggtkp4ldoER5xgWHVKg CUujW8Wk0Vk8T3wk+gVlIYNnYxjeOYqAxSid2UwZviFoFXmR7kaFfoYEi/jHzzECu4p9 1gpw== X-Forwarded-Encrypted: i=1; AKwUvBzjhne3BaKbGk/G1G1RSodjPkJqzWsrRgbGaCeosGs9mehZ4jPh8kY4kw78ck/HMSOi4gllMaGGQsY=@vger.kernel.org X-Gm-Message-State: AFuF++nvxvLIH8eZiN45abP10YwVAQuq9afoWvDBoeWxJX75ejdbcMcc w9EXy6MxRPd/UcoaL8jhFQo6h+C4cQ/Hi/eGOUXbtnuiNI3FRB3r9jZlut+ycAmmyGR7fV+q7Id rdvadEkCm9pwWF2rpe9duYuBJMV348ZHoALXUfAy+q4UVOPYEIjvY/5jkk91y1yc= X-Gm-Gg: AYBFou0ZQfksfZQLrpKwP5YjuDTDZ8FxDAKvrMqYQZWRCz0Vt7i1ayMRruyo2f3rFeR BULJVjKPyck/gTApk5K2tXLTNOfvtfDeD8JCuUpjOKLAQJaDMCIvuLrdgq2BAga0UgEzABf73Zh Pbv3bTD2KvCQe2JJOI5x3e0k7uoMpOZqGlXQCwke0xEDvDHftuhESm+PBbmOaEq6N5NVhbYw7SP mVBITXv7OIwk7ZQSPKpjFNkgdi7/3ECK0uflnweh4opnZe8b/vLUqctKCFncTxskXfcfvV/AvTC tg+5y1bCVbGtoO0bFk0pskbL04UdJPcogb5ia4QLg3bj3IT4pKKnbF0uEzPla0RK2XHzbEvI/wX dRV+uObYyAIICsKXd31MrE34JSXdnrTUmJF8wex1U+aoYQoMM6Jbb4rWOBioZqZQ= X-Received: by 2002:a17:90b:4b0f:b0:38f:dec8:f7e9 with SMTP id 98e67ed59e1d1-39aee152d1cmr18587611a91.12.1788448471214; Thu, 03 Sep 2026 08:14:31 -0700 (PDT) X-Received: by 2002:a17:90b:4b0f:b0:38f:dec8:f7e9 with SMTP id 98e67ed59e1d1-39aee152d1cmr18587536a91.12.1788448470695; Thu, 03 Sep 2026 08:14:30 -0700 (PDT) Received: from [10.133.33.96] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b083f04d1sm5864497a91.8.2026.09.03.08.14.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 08:14:30 -0700 (PDT) Message-ID: <7325c6a9-8e8d-48e0-b01a-68a287e7af5d@oss.qualcomm.com> Date: Thu, 3 Sep 2026 23:14:24 +0800 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/12] clk: qcom: ipq-cmn-pll: Add NSS clock support To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com References: <20260814-qcom_ipq5210_cmnpll-v3-0-21c3db378611@oss.qualcomm.com> <20260814-qcom_ipq5210_cmnpll-v3-5-21c3db378611@oss.qualcomm.com> <9e6a0e54-d16c-4b8c-9034-1e682a420e7c@oss.qualcomm.com> Content-Language: en-US From: Jie Luo In-Reply-To: <9e6a0e54-d16c-4b8c-9034-1e682a420e7c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDEzMiBTYWx0ZWRfX6vLx2T4VPlp8 jcfjXPzeKQUuOpyAv94psCapE4/UpT/j19GPTw0Yk5YsXNioP+BQzQSNQPy0Nr1Fj0tvBq905Sb 7gmE8CuUZSG9NMGGY4gLrhjf9rE6T3+kq5mT38w4ppaXlk2hfULKTCk04germ36WPeqLxC07df+ EopCeTX5uKZzUJfTkH05Ohoz8GmDjDInRApf2gc4xmVrfezK80iTZSzPt1z0y/tr10Imn8MH8wQ CBmwmQuC2xLAsG/0gWxFUqoVpempt/OsRScGb0Y0BepaoFs2eU1j6LIviI8GqsiAZeSsqrTKxEn 9OR10mFq/ugez6HiKRkMH+Ex5oqHN6Y/MpLJzs7OGc51uomvdSisoQnDZ3BjqDV6QiHsyy0Uixl Ng0aEXRX0onbB6dt8by3zKwRlXN90Iohic6XU46xv3R9UwuNsBQWa3plOdX726PF1/tEqhQtNm8 abyT2flh+OHhGofW41g== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDEzMiBTYWx0ZWRfXyBbNIF6O7DCa UEVW4jypxvxNlMDJI0l7Qd+d+E0T0msbMjuou21Fm0iE4Sc/eZAvagAizLGZKTzk+IAVLoyXqf4 oFSXmjUKGA6WGGUzWHL2CD8ifS06QSA= X-Proofpoint-GUID: DFugUXLzSFXFuyNWbXfq80QpSmNLzobK X-Proofpoint-ORIG-GUID: DFugUXLzSFXFuyNWbXfq80QpSmNLzobK X-Authority-Analysis: v=2.4 cv=LZ4MLDfi c=1 sm=1 tr=0 ts=6a998ed8 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=OvnJboicBg_-wI3pKI4A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_04,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030132 On 9/3/2026 7:56 PM, Konrad Dybcio wrote: > On 8/14/26 2:48 PM, Luo Jie wrote: >> The NSS (network subsystem) clock's parent is cmn_pll_div2 (CMN PLL >> rate / 2); it is then further divided by a configurable 6-bit divider. >> >> Register the NSS clock through a new ipq_cmn_pll_regmap_div_register() >> helper, built as a plain struct clk_regmap_div instance instead of >> hand-rolling recalc_rate/set_rate. The helper takes the register field >> mask and clock name as parameters so that the upcoming PPE clock, which >> shares the same register with a different field, can reuse it. >> >> Signed-off-by: Luo Jie >> --- > > [...] > >> +static struct clk_hw *ipq_cmn_pll_regmap_div_register(struct platform_device *pdev, >> + struct regmap *regmap, >> + struct clk_hw *parent_hw, >> + const char *name, >> + u32 field_mask) > > Since we're doing clk_regmap now, you can just use the clk/qcom/common.c > infrastructure instead of NIH-ing it.. > > Konrad Thanks for taking a look. To clarify, this helper is already built on struct clk_regmap_div from clk-regmap-divider.h, using .ops = &clk_regmap_div_ops; it does not implement its own recalc_rate or set_rate operations. The wrapper only derives the shift and width from field_mask and calls devm_clk_register_regmap(). Since the NSS and PPE clocks use different fields within the same register, this avoids duplicating the registration boilerplate.