From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B29EE49AE for ; Wed, 23 Aug 2023 06:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232950AbjHWGgK (ORCPT ); Wed, 23 Aug 2023 02:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232443AbjHWGgJ (ORCPT ); Wed, 23 Aug 2023 02:36:09 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2133.outbound.protection.outlook.com [40.107.215.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C23911BE; Tue, 22 Aug 2023 23:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3J+AowXLD5kKu+W+Xn7/VEm+OLLWHYNzR3iAErRQTraM5FwgzJwwvduYhPbTG2b4FG+9lOe2QV3zszc3jnIC2sP6aBkkS/G0RnFx/Rok8v8bSuT7dx93a4RaiN1GUBIXzrbw0GI5Rntk9ZQi7PXwr1DdHmjsETR+MTGLdTY9RObsQvocdtU7esjhd8Mr22yRkDLlcx55nsZfjJE7NqAu/3vVSeN0wWa7w4uTAs3TDwLLnWj2ScDi0JiwmiLJSXTji8oQe3DTfrEozA4TbUOezCQ9RalXc6qVsPFz9f71dZw2OfKbDMu6ONislXyiv4ueGIrEPm8u4CZ2n686y4bLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iDqeIAerwMCVsfRmXiqbd6CbesupNZFLDot9zRpJvvY=; b=UcXmNGEb3GLChCQG5jK4br8yLjLFjg6QfyzOAT7jeU3t03GyY5nolcP8YzVTjjVdKzpaVi5PlKMMxxG58cnnTKbd8eWJB9cjAA20CUghSsJ9i0iFHaAGcBYI1yykAwN9O5TdBtm/1QhEllk/IPp1yVbv2SdbDNSQyVfpZ6gbdK2BGk6/1pRanM7TIwW2TDZ4C5JzaZ2tbWbj+XANtjXn8sj/I6exXl55kE6fyPllM/qer9JgttL83tE2e1JWzQdcKA5bLsRVCHFl6ahId2NZsKqjo8oRdQgN8ywMVVaCW08kzUHD5qO8Uvpw2l+IobnTOxKHXAmQ4fXj2gXhrwJzcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amlogic.com; dmarc=pass action=none header.from=amlogic.com; dkim=pass header.d=amlogic.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amlogic.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDqeIAerwMCVsfRmXiqbd6CbesupNZFLDot9zRpJvvY=; b=bOQ3J1L3yfhjSUZ4infDioWOzx0aeJ1qKL9Nod9eBBkpI+L5HUssojrs2QbLERKb4C2CSp1c8e/yzuGwlrjh6xKaOffn7fW3g+85rQARXzaS7RvqyLX6G7kj5wxpEYcXS0DXcMfwUUZQr0E8yoyME/iau/XNZuoDMRasMbe5rZoTjty24VMRPky4eRHx1nh47+gN6j8UdSsDqH/C3P4s2PRt5DALiiRQIs8ZRcX2/EyPN130Nn4lJQvmafdZ4t9I7Veo5+rZ0Hvmaf4Ok/F+dNnQ3/wrLv2t8oGhMLiXEFUZuvETI1FeLeHna10IqLb7QwUvRT933F8NKeXmFP2Y5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amlogic.com; Received: from SG2PR03MB6730.apcprd03.prod.outlook.com (2603:1096:4:1d5::9) by TYZPR03MB5405.apcprd03.prod.outlook.com (2603:1096:400:3c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.26; Wed, 23 Aug 2023 06:36:01 +0000 Received: from SG2PR03MB6730.apcprd03.prod.outlook.com ([fe80::6f04:4b62:1127:59ed]) by SG2PR03MB6730.apcprd03.prod.outlook.com ([fe80::6f04:4b62:1127:59ed%4]) with mapi id 15.20.6678.029; Wed, 23 Aug 2023 06:36:01 +0000 Message-ID: <754de03e-2601-5696-c07c-caef88b974ef@amlogic.com> Date: Wed, 23 Aug 2023 14:35:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH V10 1/4] dt-bindings: clock: document Amlogic S4 SoC PLL clock controller Content-Language: en-US To: Krzysztof Kozlowski , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Jerome Brunet , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Martin Blumenstingl Cc: kelvin.zhang@amlogic.com, qi.duan@amlogic.com References: <20230822082750.27633-1-yu.tu@amlogic.com> <20230822082750.27633-2-yu.tu@amlogic.com> <4db8ba95-0d0d-0d1c-1d90-29833f0405ae@linaro.org> From: Yu Tu In-Reply-To: <4db8ba95-0d0d-0d1c-1d90-29833f0405ae@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR06CA0215.apcprd06.prod.outlook.com (2603:1096:4:68::23) To SG2PR03MB6730.apcprd03.prod.outlook.com (2603:1096:4:1d5::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PR03MB6730:EE_|TYZPR03MB5405:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e1a96e5-2d0f-4f26-6b7a-08dba3a337aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hT501QmqJIFytAaQgFJ4IWXH3mfZBR0jbh0/0IYxVNrmwwKJrqmXVr7RdE9QSxsLAhbIa10rJjXa0DlHA6qWOgKypr3bdt0V5/P50i2lOXToLrTq9H0fB1SsARYOL9ttP2Uvoz+fWXF2t4UpnRsc1YXVByQxg+HmmNbRKKvGsfwsqz83LwpgqxTQ7gi/3wJW2NmikKYHRl3qdaqDwL2jZ5aq9jZd45n9DpHk2S8HNL3uvpoHrlEhzaoGfNxERlGlLZ/KxzIUGdv9nD+9vQX39gtBCbUEaYp1u2VKQlbsgyX6lHM9PIs74dVDXobtxJfIXuMc9qhD3dfwQn+e4l/HUkQShFqOmupdEo7KKmXNTyQfnOIiqodc+kTvVm/QBHPA1gxq4uFn6ThISzXjGOhY9DmSVChlzN2OxsVAZXm3+IPdflasaBMezIBlfMRLrcc/kM10/fs4kHepqOZ4YVp9WjplzmZmew43gkwdl+McoGMFbhBi3ae+sDWe4699vsd2sMSqFTR/aqVzSC6FnSWcXa4+/kSMOzbLnnvihxUa3239BmLUE6Ic68e8W+prFjChz83RMsp/2Dh84g7jBAlrJBkpQ091W0LCLQC89Epfv1+oVeFLjwUY9rHc4Ydi+NKs3XDynoRyni29tCMpsIKymYM9avkmPscl7VpMeLxxK5kRA9nNVTtegCLWH/4bTv4lSn2d9tTS5tgxyRcEhcquEcHjJM9zESSmdMKVYNBurlvl8Ww39Xz91RsKmePtmxlZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR03MB6730.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(366004)(396003)(39850400004)(186009)(1800799009)(451199024)(6506007)(6486002)(6666004)(53546011)(6512007)(83380400001)(921005)(86362001)(31696002)(38100700002)(36756003)(26005)(2616005)(107886003)(2906002)(316002)(66946007)(66556008)(66476007)(41300700001)(110136005)(5660300002)(12101799020)(44832011)(7416002)(31686004)(4326008)(8676002)(8936002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUw3eGNLLysrWXVPS1RNRWVtUDNsOTg1ZC9mZlo0Wm9kR00ybmZMYlNqSGR4?= =?utf-8?B?YVRwOE4vT2VuSWV5TDZUM1J4QitZWC9WMkF3UnA1ZGNYSjg3YWJ5cFdSSEdG?= =?utf-8?B?NG9UczNtNThjak5ZL2gvOXlzbXJIT2czS3REUkd5S3JPOGFQak9qZ3FqckpK?= =?utf-8?B?anpsMHhDTzQ0cDNhUDlFaGlYTzJTaTEyVjFwejBseUwrZE5rbXBDTDFWdlB5?= =?utf-8?B?QzkvM1pGdXRxWHplM0Q4L1pTSWlUTHFOSEVJYXZScUMxMlQzSFp1M0tyblcz?= =?utf-8?B?TzRwU25jMUFyRTl2MkRkYjF2STRUeGdSNVNSNDUvdms0YWlxWGtaTW9uVWRv?= =?utf-8?B?c1hhYXUvaVdNU0dySTJjTjd6Y0tHWHNiUklOWE9xRFNzL0JBdE9KYnJhOVBZ?= =?utf-8?B?cDRhWVNJV3F3Q1pyeWR4RWZKdlljOUNleUlmOVFPVEpJQjVra0dkNWs0OGxn?= =?utf-8?B?OHZyTTNMWGJoWDFvUVRNd2F5RHI4UnI4RjZQV2xvRk1HQVdhNUhRekpMZ2g5?= =?utf-8?B?VGo4b3hoYm9zUWVpMGJwL3ZwSWNCR1Brd2xiMU1MY1pnYkRlVDZqT0ZBNzI5?= =?utf-8?B?WmdQbGhaR094MWk5WXlaZjdHaFJiUk93QU9VQVU1L3R2MW9kWUF3ZUt2RE13?= =?utf-8?B?NVgvcE1UeElXZkNhRFByM3o5T3d2TW1mSWJCZGVBNllmOGdQK1E5bHA4ZlBU?= =?utf-8?B?SlV6RnB3bkpmMkRIV1Z4dmNKTUljNDFiWUFzNVdvTjQ2Uk1ZSFVpd0xPaVhJ?= =?utf-8?B?WnFJSHNIOGxWaDJZN3pqZjZUZ0M1bWlXS1RiY3N0alJCVGlMWlUzUWRGRXNa?= =?utf-8?B?V0w4d2JKUnEwRHU5WjdTUEtqR2RISUNCT2pnOHhWYmJWWUpoSStnMUxmbnlx?= =?utf-8?B?TExoRkhXQUs1eXdKVkd1NzFYYlhidExnWndPSXVOczJyRlZuNUdEN2JCK0tq?= =?utf-8?B?bmZXOW9wTUdyMUlKdFlJZXRKSjljaDQ4eUtVSVIxcHRsR0FFWUZoa0g5cEZn?= =?utf-8?B?cUg4WlhuZWNlYVlhR2NpWG5sYXplcjhjY3lDaUxUbnR4bzNSTytvU3hjNjd5?= =?utf-8?B?Q3dQd2dtM1kxZkUvWUJkL1lwcEZXN0syaGZieHlsb0xDTWRrOS9hYlp4RDBG?= =?utf-8?B?SUNhOTUrM3A0SjlLN1FleXVLUVJROHVZSzFvY29KaTArZXdhUFNiWlNMbktM?= =?utf-8?B?WmZDOU1lQ21ReVJadUJ3MHBNK0xoMFBMZDVSY0tDZ1pwcThPYVFFK2JNMTlF?= =?utf-8?B?MTFSWFh3ZHluVFRrbk4yRDUrMlZWK2wxM2Y3dTZkVWRLOU10Qnp1eTFtRG1l?= =?utf-8?B?S0I5dEgzTjBVSS9UOHl0SDl4U2huV0I2NVVwZzlEUkZKQ2xZbFowQkJHU091?= =?utf-8?B?YkZHdklhWld0Mmg3UVd6WGU0S2pZVUJNd0dHYU5HYTlvL3loZFRPdHVtdG9S?= =?utf-8?B?QXJlSEp6VVpTR0JqLzhGeGxqVWE5VmpOYS9aaDcwSzZvbW1NS2hMMEpKdHVX?= =?utf-8?B?eUZYSVRCcll2N1hIRnJLVEpsZG5sdURzdHY1TVNiZUhXcXlxZDc0TUpkNDlt?= =?utf-8?B?bFBMWDVvdXFBUFVlQTRHUU1tdVp3aytnZEtjU3hndVc0dzc3MjdNRDhJbDYy?= =?utf-8?B?REpoY1M4RGprdi9icmdIdnlHMytCcFlTOVcvc3JkM2pwVDdjRmdGTTNJS25v?= =?utf-8?B?RHBNdjVuWW8zdkZqTzdUeHhNSEJDK0x0emUzUzRMZnJkSEFVeEYvV3dxUkZj?= =?utf-8?B?dlBxdTVudExFTndoQlFBbHI0K2dyMGtXQ2FjOEQ4RHMzUndjSXBRV1NCNDZU?= =?utf-8?B?VWZXZkNONmpaa0I3ZWtKdGhKTzd4RUpEdXRnYkwyZDd4ck5paG9yb2xrSkhZ?= =?utf-8?B?WEw2SlNUZDZRU3F0a1RmRStkUmtTZ08xSW1oanZ1WmRpOUthUlpTRjlhMHNh?= =?utf-8?B?R3hDTmt3a0MwT1pvck9UbVR4bndRYmFQb3JxbGNpSExWRUdjZ3BpTUJMOSt5?= =?utf-8?B?VHc3N3dwMllOV2UvdFk3YTNmdnJBMmRVVnVsaE9nMngrVDFHK3M3Q2o2TU5s?= =?utf-8?B?WTQweGxoVERmcVRiZzg4QzAwRDgxb0p3WTNNWGdCWFZVMTExNHJSTWlQYXZL?= =?utf-8?Q?ofH58kJ0yynu8INa1Dh20scRq?= X-OriginatorOrg: amlogic.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1a96e5-2d0f-4f26-6b7a-08dba3a337aa X-MS-Exchange-CrossTenant-AuthSource: SG2PR03MB6730.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2023 06:36:01.3435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ys9McPOh1BzwPuDOyvFruk6n9l4D8TjziBMuI3sqha+TPH8agdawOZ7HuOBQGTDcb7TgU1noF+uuNIOimhmRiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5405 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2023/8/23 14:27, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 23/08/2023 08:20, Yu Tu wrote: >> >> >> On 2023/8/23 13:43, Krzysztof Kozlowski wrote: >>> >>> [ EXTERNAL EMAIL ] >>> >>> On 23/08/2023 04:24, Yu Tu wrote: >>>> >>>> >>>> On 2023/8/23 0:32, Krzysztof Kozlowski wrote: >>>>> [ EXTERNAL EMAIL ] >>>>>> On 22/08/2023 10:27, Yu Tu wrote: >>>>>> Add the S4 PLL clock controller dt-bindings in the S4 SoC family. >>>>>> >>>>>> Signed-off-by: Yu Tu >>>>> >>>>> Lovely. I sent youa friendly reminder at v8 which turns our you >>>>> ignored. You keep ignoring, I will start ignoring as well from now on. >>>> >>>> Hi Krzysztof， >>>> >>>> Sorry. I did not forget the friendly reminder in v8, I consulted you for >>>> this at the time, so I re-sent V9 after adding the tag. Because it was >>>> just "meson" that was removed. But V10 is based on Neil's patch, which I >>>> think is a bit of a change. So I didn't dare add it. Instead of >>>> forgetting your reminder. >>>> >>>> So what should I do, I'll follow your advice exactly. >>> >>> I don't think there was much difference between the version, which >>> received the review, and the current patch. Otherwise your changelog >>> should say that you drop Rb tag. Rebasing of something somewhere is not >>> the reason, so please describe what are the differences in the patch? >> >> The current patch and V9 patch difference is mainly based on Neil patch >> I put "include/dt - bindings/clock/amlogic,s4-pll-clkc.h" this document >> describes the clock index all exposed. > > Adding one include is insignificant change, thus any Rb tags should stay. I got it. >> >> Next, I should add Rob's tag and resend it. If you have any other >> suggestions, please tell me and I will strictly follow your suggestions. > > I cannot add someone's tag, thus on your next version you must include > it. I told this last time. Well. I remember your advice. Guaranteed no errors in the next version. > > Best regards, > Krzysztof >