From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Val Packett <val@packett.cool>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Adam Skladowski <a39.skl@gmail.com>,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: qcom,sm6115-dispcc: Define MDSS resets
Date: Sun, 1 Mar 2026 14:16:23 +0100 [thread overview]
Message-ID: <76f707b7-ff2a-43e1-9bba-d3efd801c58a@kernel.org> (raw)
In-Reply-To: <uqfdlsgc3ct23hgpul7l5towiry3p2ouneuaikbzi7x5h6hxy4@5l2hhc2m5t6l>
On 01/03/2026 14:14, Dmitry Baryshkov wrote:
> On Sun, Mar 01, 2026 at 12:52:57PM +0100, Krzysztof Kozlowski wrote:
>> On Sat, Feb 28, 2026 at 05:41:27PM -0300, Val Packett wrote:
>>> Add the missing defines for MDSS resets, which are necessary to reset
>>> the display subsystem in order to avoid issues caused by state left over
>>> from the bootloader.
>>>
>>> While here, align comment style with other SoCs.
>>>
>>> Fixes: 38557c6fc077 ("dt-bindings: clock: add QCOM SM6115 display clock bindings")
>>
>> IMO this is still not fix. Missing feature in original posting is not a
>> bug, it's just incomplete posting which is in general accepted.
>>
>> Your commit msg tries to explain the bug and I see nothing relevant to
>> this binding. From that explanation I see nothing wrong in mentioned
>> fixed commit.
>>
>> Please drop fixes.
>
> Here we have an interesting situation. Patches for the bindings and for
> the clock driver are not fixes. The DT patch is a fix, because MDSS /
> DPU can misbehave when switching from the bootloader configuration to
> the running system.
If these are not fixes, then they should not carry a tag claiming they
are fixes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-01 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 20:41 [PATCH v2 0/6] SM6115/SM6125 MDSS core reset Val Packett
2026-02-28 20:41 ` [PATCH v2 1/6] dt-bindings: clock: qcom,sm6115-dispcc: Define MDSS resets Val Packett
2026-03-01 11:52 ` Krzysztof Kozlowski
2026-03-01 13:14 ` Dmitry Baryshkov
2026-03-01 13:16 ` Krzysztof Kozlowski [this message]
2026-02-28 20:41 ` [PATCH v2 2/6] dt-bindings: clock: qcom,dispcc-sm6125: " Val Packett
2026-03-01 11:53 ` Krzysztof Kozlowski
2026-02-28 20:41 ` [PATCH v2 3/6] clk: qcom: dispcc-sm6115: Add missing " Val Packett
2026-03-01 11:54 ` Krzysztof Kozlowski
2026-02-28 20:41 ` [PATCH v2 4/6] clk: qcom: dispcc-sm6125: " Val Packett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76f707b7-ff2a-43e1-9bba-d3efd801c58a@kernel.org \
--to=krzk@kernel.org \
--cc=a39.skl@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=val@packett.cool \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox