From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: prevent __of_clk_get_hw_from_provider() from returning NULL
Date: Fri, 05 Aug 2016 10:29:39 +0200 [thread overview]
Message-ID: <792d2cb8-06bf-7406-b79a-06c16b977bd4@samsung.com> (raw)
In-Reply-To: <20160804205734.GA15690@codeaurora.org>
On 08/04/2016 10:57 PM, Stephen Boyd wrote:
> On 07/19, Masahiro Yamada wrote:
>> > The .get(_hw) callback of an OF clock provider can return a NULL
>> > pointer in some cases.
>> >
>> > For example, of_clk_src_onecell_get() returns NULL for index 1 of a
>> > sparse array of clocks like follows:
>> >
>> > clk_num == 3
>> > idx 0: UART clk
>> > idx 1: NULL (no clk is allocated)
>> > idx 2: I2C clk
>> >
>> > In such cases, clk_get() successfully returns NULL.
I remember running into same issue before, we have addressed
it by initializing the array of clocks with some errno value,
e.g ERR_PTR(-ENOENT), so there is no chance to get NULL from
the array - either a valid clk pointer or an ERR_PTR() value.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2016-08-05 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 9:03 [PATCH] clk: prevent __of_clk_get_hw_from_provider() from returning NULL Masahiro Yamada
2016-08-04 20:57 ` Stephen Boyd
2016-08-05 8:29 ` Sylwester Nawrocki [this message]
2016-08-07 17:05 ` Masahiro Yamada
2016-08-10 8:16 ` Masahiro Yamada
2016-08-10 23:23 ` Stephen Boyd
2016-08-12 6:59 ` Masahiro Yamada
2016-08-13 7:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=792d2cb8-06bf-7406-b79a-06c16b977bd4@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox