From: <Eugen.Hristev@microchip.com>
To: <saravanak@google.com>, <Tudor.Ambarus@microchip.com>
Cc: <alexandre.belloni@bootlin.com>, <a.fatoum@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <sboyd@kernel.org>,
<gregkh@linuxfoundation.org>, <mturquette@baylibre.com>,
<linux-clk@vger.kernel.org>, <krzk@kernel.org>,
<mirq-linux@rere.qmqm.pl>, <Ludovic.Desroches@microchip.com>,
<geert@linux-m68k.org>, <Codrin.Ciubotariu@microchip.com>,
<Claudiu.Beznea@microchip.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks
Date: Thu, 4 Feb 2021 12:46:43 +0000 [thread overview]
Message-ID: <7a9e6113-3281-04c8-00e2-c5286d8b0b01@microchip.com> (raw)
In-Reply-To: <CAGETcx9ki6tM7Z8B8ghm9cZVNbwUo9rQPY1H0-s2rRifC=_m8A@mail.gmail.com>
On 03.02.2021 20:15, Saravana Kannan wrote:
> On Wed, Feb 3, 2021 at 7:43 AM Tudor Ambarus
> <tudor.ambarus@microchip.com> wrote:
>>
>> These are all "early clocks" that require initialization just at
>> of_clk_init() time. Use CLK_OF_DECLARE() to declare them.
>>
>> This also fixes a problem that was spotted when fw_devlink was
>> set to 'on' by default: the boards failed to boot. The reason is
>> that CLK_OF_DECLARE_DRIVER() clears the OF_POPULATED and causes
>> the consumers of the clock to be postponed by fw_devlink until
>> the second initialization routine of the clock has been completed.
>> One of the consumers of the clock is the timer, which is used as a
>> clocksource, and needs the clock initialized early. Postponing the
>> timers caused the fail at boot.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Thanks Tudor!
> Acked-by: Saravana Kannan <saravanak@google.com>
>
> -Saravana
>
>> ---
>> Tested on sama5d2_xplained.
>>
For sama5d3_xplained, sama5d4_xplained,
Tested-by: Eugen Hristev <eugen.hristev@microchip.com>
next prev parent reply other threads:[~2021-02-04 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:43 [PATCH] clk: at91: Fix the declaration of the clocks Tudor Ambarus
2021-02-03 18:15 ` Saravana Kannan
2021-02-04 12:46 ` Eugen.Hristev [this message]
2021-02-04 13:54 ` Nicolas Ferre
2021-02-08 9:49 ` Tudor.Ambarus
2021-02-10 0:54 ` Stephen Boyd
2021-02-10 0:56 ` Saravana Kannan
2021-02-10 8:51 ` Geert Uytterhoeven
2021-02-10 8:57 ` Saravana Kannan
2021-02-10 9:10 ` Geert Uytterhoeven
2021-02-10 9:00 ` Greg Kroah-Hartman
2021-02-10 16:22 ` Rob Herring
2021-02-10 0:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9e6113-3281-04c8-00e2-c5286d8b0b01@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mturquette@baylibre.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox