public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@nbd.name>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, John Crispin <john@phrozen.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC
Date: Wed, 22 Dec 2021 16:35:02 +0100	[thread overview]
Message-ID: <7ae0494f-438e-f147-913f-e0f28eb5b3bf@nbd.name> (raw)
In-Reply-To: <CAK8P3a3Qy8FJpACTqt85Enm72aJ=vzUfiEMZ4=dRqFmunyOm1Q@mail.gmail.com>

On 2021-12-21 15:06, Arnd Bergmann wrote:
> On Mon, Dec 20, 2021 at 10:18 PM Felix Fietkau <nbd@nbd.name> wrote:
>>
>> This driver only registers fixed rate clocks, since the clocks are fully
>> initialized by the boot loader and should not be changed later, according
>> to Airoha.
>>
>> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> 
> I don't have any particular comments on the driver itself. I'm happy
> to merge it through
> the soc tree for the initial support of the clk maintainers are ok
> with it and have reviewed
> the actual code.
> 
>>  drivers/clk/Kconfig      |   9 +
>>  drivers/clk/Makefile     |   1 +
>>  drivers/clk/clk-en7523.c | 350 +++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 360 insertions(+)
>>  create mode 100644 drivers/clk/clk-en7523.c
> 
> I think this should go into drivers/clk/mediatek, as it probably shares
> some of the logic with the mt762x drivers in there. I'd suggest adding the
> maintainers for those drivers to Cc for additional review.
I don't think it shares any logic with the other drivers, but since 
Airoha is a subsidiary of Mediatek, I guess it makes sense to move it there.

- Felix

      reply	other threads:[~2021-12-22 15:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211220211854.89452-1-nbd@nbd.name>
2021-12-20 21:18 ` [PATCH v8 06/14] dt-bindings: Add en7523-scu device tree binding documentation Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC Felix Fietkau
2021-12-21 14:06   ` Arnd Bergmann
2021-12-22 15:35     ` Felix Fietkau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae0494f-438e-f147-913f-e0f28eb5b3bf@nbd.name \
    --to=nbd@nbd.name \
    --cc=arnd@arndb.de \
    --cc=john@phrozen.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox