From: Stephen Boyd <sboyd@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: mux: let clk_mux_val_to_index return U8_MAX in the error case
Date: Thu, 13 Apr 2023 12:10:23 -0700 [thread overview]
Message-ID: <7b16c4d703dc00efd6e1b4062b5fd6d7.sboyd@kernel.org> (raw)
In-Reply-To: <af85927b-0da3-3495-2ed4-64bda91cd239@gmail.com>
Quoting Heiner Kallweit (2023-04-11 23:19:04)
> Currently this function may return a negative errno, but almost no
> user checks for the error case. Only imx_clk_gpr_mux_get_parent()
> does, but mentions in a comment that they'd prefer a dummy value.
> Other users cast the negative errno to u8 instead, what may result
> in unwanted results.
> Let's deal with this by returning u8 and U8_MAX in the error case.
> Then clk_core_get_parent_by_index() can detect that the index is
> out of range.
Is this causing problems for you?
next prev parent reply other threads:[~2023-04-13 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 6:19 [PATCH] clk: mux: let clk_mux_val_to_index return U8_MAX in the error case Heiner Kallweit
2023-04-13 19:10 ` Stephen Boyd [this message]
2023-04-13 19:27 ` Heiner Kallweit
2023-04-13 20:30 ` Stephen Boyd
2023-04-13 20:47 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b16c4d703dc00efd6e1b4062b5fd6d7.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox