Re: [RFC PATCH v5 5/9] dt-binding: tegra: Add VI and CSI bindings

Sowjanya Komatineni
2020-03-24T21:16:18Z

On 3/24/20 12:20 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 23.03.2020 20:52, Sowjanya Komatineni пишет:
>> Tegra contains VI controller which can support up to 6 MIPI CSI
>> camera sensors.
>>
>> Each Tegra CSI port from CSI unit can be one-to-one mapper to
>> VI channel and can capture from an external camera sensor or
>> from built-in test pattern generator.
>>
>> This patch adds dt-bindings for Tegra VI and CSI.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> .../display/tegra/nvidia,tegra20-host1x.txt | 67 +++++++++++++++++-----
>> 1 file changed, 54 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
>> index 9999255..9421569 100644
>> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
>> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
>> @@ -40,14 +40,25 @@ of the following host1x client modules:
>>
>> Required properties:
>> - compatible: "nvidia,tegra<chip>-vi"
>> - - reg: Physical base address and length of the controller's registers.
>> + - reg: Physical base address and length of the controller registers.
>> - interrupts: The interrupt outputs from the controller.
>> - - clocks: Must contain one entry, for the module clock.
>> + - clocks: Must contain an entry for the module clock "vi"
>> See ../clocks/clock-bindings.txt for details.
>> - - resets: Must contain an entry for each entry in reset-names.
>> - See ../reset/reset.txt for details.
>> - - reset-names: Must include the following entries:
>> - - vi
> This should be a wrong change because ARM32 Tegra SoCs do not use power
> domain.

Will update tegra20-host1x.txt to specify power-domains for Tegra210+
and to keep reset properties for prior Tegra210.

>> + - power-domains: Must include venc powergate node as vi is in VE partition.