From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6FBC43603 for ; Wed, 18 Dec 2019 07:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A73A624650 for ; Wed, 18 Dec 2019 07:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hl8cTDIZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726717AbfLRHBa (ORCPT ); Wed, 18 Dec 2019 02:01:30 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40823 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbfLRHBa (ORCPT ); Wed, 18 Dec 2019 02:01:30 -0500 Received: by mail-lj1-f195.google.com with SMTP id u1so868690ljk.7; Tue, 17 Dec 2019 23:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+p/vYJ+Acwdq7pJ0nMPFR31OSAJcgX2TSg9PFEvCQRY=; b=Hl8cTDIZ72dcavX4+utz+hbSBUpcgtL6EShoe3hxJ2MjU5WX74RoMeRT7nfas2Stec yyACkErYSXVAgQmBVZlqSNuR4S9QOpELBsOpk4kYHeZBSX0BsD6fqmmwpeBKRBh1U0sL ur6z8Y5PFEvLyC5zVYX9AxcTFb0QtGnltcAddOKYppM8eJJU9LlQeGlKTocHcEe7gwww LnxvdeUJ75Y7rr8lmFpOEeQIYnJkjf+nV7sMNwFYIPEuE2Opx4Cc7FVCRs7+13pLsPGP nws/ot+Tmx+kksnZPrc8JAo9/seXz1zXt4cTNZiO9Jwz6vgUpPvB64euKEPgU05GsMAm xeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+p/vYJ+Acwdq7pJ0nMPFR31OSAJcgX2TSg9PFEvCQRY=; b=ndJCHImvnlgyqXjfUoHSO+Jwdv0J2f0hQbIXzb7Yvh1Hqxg4TyLDxKdjGEQBHtIUui mmxeENVrxRe/lru+ZCsWNXvy8WsaOh8gUkWzG7vL7ZnY1BJFvJk5h5rvQpW7YR6WbeO0 tjSZGopMLTld1c4MN7Hw4HGD3TSHm3NxP2smVyapNAaKK5DjbTaeAoT1KuIdZefOTKhJ QruYdt7rNtE7lZLvptbndWYRS4mfNYuOitUVJD18rSGsvc+oTGwivWv3RAD4K6yaHf2t Stt9T1Y4ehYtn00Ujag7+aYlLrN5wL2V/P7Bjbpq4LxxYrxouSBW/FEyK4gixbUDrAtJ g2sg== X-Gm-Message-State: APjAAAX2feHPYpHb5AtYWfyKYYgX2c37H6zfvliH+Hgs5a9JkrdQSGuB tYwr/psHEwsNLAeNRIiZGWQlVEn/ X-Google-Smtp-Source: APXvYqxyLaBoom5r4eD5xcChn70Qc4vj25pehXcCiGtGzjZIe1UxVFMasLagU0H8p4BFEbUpwMv1Pw== X-Received: by 2002:a2e:9b52:: with SMTP id o18mr533308ljj.205.1576652486951; Tue, 17 Dec 2019 23:01:26 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id f24sm524156ljm.12.2019.12.17.23.01.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 23:01:26 -0800 (PST) Subject: Re: [PATCH v4 13/19] ASoC: tegra: Add fallback implementation for audio mclk From: Dmitry Osipenko To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, spujar@nvidia.com, josephl@nvidia.com, daniel.lezcano@linaro.org, mmaddireddy@nvidia.com, markz@nvidia.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1576613046-17159-1-git-send-email-skomatineni@nvidia.com> <1576613046-17159-14-git-send-email-skomatineni@nvidia.com> Message-ID: <7e49fef8-112c-1694-9316-7a23db8a01a4@gmail.com> Date: Wed, 18 Dec 2019 10:01:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 18.12.2019 09:59, Dmitry Osipenko пишет: > 17.12.2019 23:04, Sowjanya Komatineni пишет: >> mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks >> are moved to Tegra PMC driver with pmc as clock provider and using pmc >> clock ids. >> >> New device tree uses clk_out_1 from pmc clock provider. >> >> So, this patch adds implementation for mclk fallback to extern1 when >> retrieving mclk returns -ENOENT to be backward compatible of new device >> tree with older kernels. >> >> Signed-off-by: Sowjanya Komatineni >> --- >> sound/soc/tegra/tegra_asoc_utils.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/sound/soc/tegra/tegra_asoc_utils.c b/sound/soc/tegra/tegra_asoc_utils.c >> index fe9ca8acd0fb..1b88c6043082 100644 >> --- a/sound/soc/tegra/tegra_asoc_utils.c >> +++ b/sound/soc/tegra/tegra_asoc_utils.c >> @@ -191,7 +191,16 @@ int tegra_asoc_utils_init(struct tegra_asoc_utils_data *data, >> data->clk_cdev1 = devm_clk_get(dev, "mclk"); >> if (IS_ERR(data->clk_cdev1)) { >> dev_err(data->dev, "Can't retrieve clk cdev1\n"); >> - return PTR_ERR(data->clk_cdev1); >> + if (PTR_ERR(data->clk_cdev1) != -ENOENT) >> + return PTR_ERR(data->clk_cdev1); >> + /* Fall back to extern1 */ >> + data->clk_cdev1 = devm_clk_get(dev, "extern1"); >> + if (IS_ERR(data->clk_cdev1)) { >> + dev_err(data->dev, "Can't retrieve clk extern1\n"); >> + return PTR_ERR(data->clk_cdev1); >> + } >> + >> + dev_err(data->dev, "Falling back to extern1\n"); >> } >> >> /* >> > > [ 1.769091] ------------[ cut here ]------------ > [ 1.769249] WARNING: CPU: 2 PID: 1 at drivers/clk/clk.c:954 > clk_core_disable+0xa5/0x1d4 > [ 1.769330] clk_out_1 already disabled > [ 1.769459] Modules linked in: > [ 1.769541] CPU: 2 PID: 1 Comm: swapper/0 Not tainted > 5.5.0-rc1-next-20191213-00167-g6b9fbcdac8f3-dirty #266 > [ 1.769676] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) > [ 1.769775] [] (unwind_backtrace) from [] > (show_stack+0x11/0x14) > [ 1.769918] [] (show_stack) from [] > (dump_stack+0x85/0x94) > [ 1.770061] [] (dump_stack) from [] > (__warn+0xc1/0xc4) > [ 1.770144] [] (__warn) from [] > (warn_slowpath_fmt+0x61/0x78) > [ 1.770285] [] (warn_slowpath_fmt) from [] > (clk_core_disable+0xa5/0x1d4) > [ 1.770427] [] (clk_core_disable) from [] > (clk_core_disable_lock+0x17/0x20) > [ 1.770516] [] (clk_core_disable_lock) from [] > (tegra_asoc_utils_set_rate+0x53/0x208) > [ 1.770662] [] (tegra_asoc_utils_set_rate) from > [] (tegra_rt5640_probe+0xd5/0x128) > [ 1.770808] [] (tegra_rt5640_probe) from [] > (platform_drv_probe+0x33/0x68) > [ 1.770958] [] (platform_drv_probe) from [] > (really_probe+0x14d/0x240) > [ 1.771099] [] (really_probe) from [] > (driver_probe_device+0x43/0x11c) > [ 1.771187] [] (driver_probe_device) from [] > (device_driver_attach+0x3d/0x40) > [ 1.771328] [] (device_driver_attach) from [] > (__driver_attach+0x37/0x78) > [ 1.771469] [] (__driver_attach) from [] > (bus_for_each_dev+0x43/0x6c) > [ 1.771609] [] (bus_for_each_dev) from [] > (bus_add_driver+0xe3/0x148) > [ 1.771692] [] (bus_add_driver) from [] > (driver_register+0x39/0xa0) > [ 1.771833] [] (driver_register) from [] > (do_one_initcall+0x43/0x1bc) > [ 1.771979] [] (do_one_initcall) from [] > (kernel_init_freeable+0x121/0x194) > [ 1.772129] [] (kernel_init_freeable) from [] > (kernel_init+0xd/0xd0) > [ 1.772215] [] (kernel_init) from [] > (ret_from_fork+0x11/0x34) > [ 1.772349] Exception stack(0xde907fb0 to 0xde907ff8) > Although, that's probably related to the "ASoC: tegra: Add initial parent configuration for audio mclk".