From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Gabor Juhos <j4g8y7@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>
Subject: Re: [PATCH] clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs
Date: Fri, 10 May 2024 19:25:54 +0200 [thread overview]
Message-ID: <7ea1f4d7-ddb9-43a1-91c0-477dfde87da1@linaro.org> (raw)
In-Reply-To: <21cedacd-f454-4eb8-9b2b-33a14592a6c1@quicinc.com>
On 10.05.2024 6:25 PM, Kathiravan Thirumoorthy wrote:
>
>
> On 5/10/2024 12:23 AM, Konrad Dybcio wrote:
>> On 9.05.2024 10:08 AM, Gabor Juhos wrote:
>>> Since the CONFIG_CTL register is only 32 bits wide in the Stromer
>>> and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the
>>> IPQ5018 and IPQ5332 configurations are not used so remove those.
>>>
>>> No functional changes.
>>>
>>> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
>>> ---
>>
>> Hm, it sounds suspicious that we'd have these settings then.. Could somebody from
>> QC please confirm that everything's alright here?
>
>
> I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register is not implemented. I see offset of CONFIG_CTL_U register is removed in the change[1] by Gabor.
Thanks
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2024-05-10 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 8:08 [PATCH] clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs Gabor Juhos
2024-05-09 18:53 ` Konrad Dybcio
2024-05-10 16:25 ` Kathiravan Thirumoorthy
2024-05-10 17:25 ` Konrad Dybcio [this message]
2024-05-13 18:44 ` Gabor Juhos
2024-05-14 16:08 ` Kathiravan Thirumoorthy
2024-05-29 2:01 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea1f4d7-ddb9-43a1-91c0-477dfde87da1@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=j4g8y7@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox