From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <khilman@baylibre.com>
Return-Path: <khilman@baylibre.com>
From: Kevin Hilman <khilman@baylibre.com>
To: Jian Hu <jian.hu@amlogic.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,  <jbrunet@baylibre.com>,  Neil Armstrong <narmstrong@baylibre.com>,  <qianggui.song@amlogic.com>,  <sboyd@kernel.org>,  <mturquette@baylibre.com>,  <yixun.lan@amlogic.com>,  <linux-kernel@vger.kernel.org>,  <bo.yang@amlogic.com>,  <qiufang.dai@amlogic.com>,  <linux-arm-kernel@lists.infradead.org>,  <carlo@caione.org>,  <linux-amlogic@lists.infradead.org>,  <sunny.luo@amlogic.com>,  <linux-clk@vger.kernel.org>,  <xingyu.chen@amlogic.com>
Subject: Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
References: <1531134767-29927-1-git-send-email-jian.hu@amlogic.com>
	<1531134767-29927-4-git-send-email-jian.hu@amlogic.com>
	<CAFBinCBB9N_p6S_-dfiV=zDCf-RYnA3C-ir6oNLC7JAfdOqqiw@mail.gmail.com>
	<be3c7332-3a7d-f8b0-efe4-e2a319273c42@amlogic.com>
Date: Mon, 16 Jul 2018 08:41:35 -0500
In-Reply-To: <be3c7332-3a7d-f8b0-efe4-e2a319273c42@amlogic.com> (Jian Hu's
	message of "Wed, 11 Jul 2018 16:05:54 +0800")
Message-ID: <7hbmb7mh68.fsf@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
List-ID: <linux-clk.vger.kernel.org>

Jian Hu <jian.hu@amlogic.com> writes:

> On 2018/7/10 5:53, Martin Blumenstingl wrote:
>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@amlogic.com> wrote:

[...]

>>> +static const struct of_device_id clkc_match_table[] = {
>>> +       { .compatible = "amlogic,g12a-clkc" },
>> I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
>> and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
>> correct - I'll CC Rob Herring on the dt-bindings patch)
>>
> For clock drivers,they omit the "meson-" prefix, But for common
> amlogic drivers use "amlogic.meson-<chip>-<ip>".
> So which type should we choose? .compatible = "amlogic,g12a-clkc or
>
> .compatible = "amlogic,meson-g12a-clkc

Please follow the existing pattern for clock drivers, omitting the
"meson-" prefix.

Kevin