* [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled
@ 2025-08-25 14:08 Alexander Stein
2025-09-05 21:40 ` Kevin Hilman
2025-09-20 5:27 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2025-08-25 14:08 UTC (permalink / raw)
To: Tero Kristo, Michael Turquette, Stephen Boyd
Cc: Matthias Schiffer, linux-omap, linux-clk, linux-kernel,
Alexander Stein
From: Matthias Schiffer <matthias.schiffer@tq-group.com>
As described in AM335x Errata Advisory 1.0.42, WKUP_DEBUGSS_CLKCTRL
can't be disabled - the clock module will just be stuck in transitioning
state forever, resulting in the following warning message after the wait
loop times out:
l3-aon-clkctrl:0000:0: failed to disable
Just add the clock to enable_init_clks, so no attempt is made to disable
it.
Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/clk/ti/clk-33xx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
index 85c50ea39e6da..9269e6a0db6a4 100644
--- a/drivers/clk/ti/clk-33xx.c
+++ b/drivers/clk/ti/clk-33xx.c
@@ -258,6 +258,8 @@ static const char *enable_init_clks[] = {
"dpll_ddr_m2_ck",
"dpll_mpu_m2_ck",
"l3_gclk",
+ /* WKUP_DEBUGSS_CLKCTRL - disable fails, AM335x Errata Advisory 1.0.42 */
+ "l3-aon-clkctrl:0000:0",
/* AM3_L3_L3_MAIN_CLKCTRL, needed during suspend */
"l3-clkctrl:00bc:0",
"l4hs_gclk",
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled
2025-08-25 14:08 [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled Alexander Stein
@ 2025-09-05 21:40 ` Kevin Hilman
2025-09-20 5:27 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2025-09-05 21:40 UTC (permalink / raw)
To: Alexander Stein, Tero Kristo, Michael Turquette, Stephen Boyd
Cc: Matthias Schiffer, linux-omap, linux-clk, linux-kernel,
Alexander Stein
Alexander Stein <alexander.stein@ew.tq-group.com> writes:
> From: Matthias Schiffer <matthias.schiffer@tq-group.com>
>
> As described in AM335x Errata Advisory 1.0.42, WKUP_DEBUGSS_CLKCTRL
> can't be disabled - the clock module will just be stuck in transitioning
> state forever, resulting in the following warning message after the wait
> loop times out:
>
> l3-aon-clkctrl:0000:0: failed to disable
>
> Just add the clock to enable_init_clks, so no attempt is made to disable
> it.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/clk/ti/clk-33xx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
> index 85c50ea39e6da..9269e6a0db6a4 100644
> --- a/drivers/clk/ti/clk-33xx.c
> +++ b/drivers/clk/ti/clk-33xx.c
> @@ -258,6 +258,8 @@ static const char *enable_init_clks[] = {
> "dpll_ddr_m2_ck",
> "dpll_mpu_m2_ck",
> "l3_gclk",
> + /* WKUP_DEBUGSS_CLKCTRL - disable fails, AM335x Errata Advisory 1.0.42 */
> + "l3-aon-clkctrl:0000:0",
> /* AM3_L3_L3_MAIN_CLKCTRL, needed during suspend */
> "l3-clkctrl:00bc:0",
> "l4hs_gclk",
> --
> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled
2025-08-25 14:08 [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled Alexander Stein
2025-09-05 21:40 ` Kevin Hilman
@ 2025-09-20 5:27 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2025-09-20 5:27 UTC (permalink / raw)
To: Alexander Stein, Michael Turquette, Tero Kristo
Cc: Matthias Schiffer, linux-omap, linux-clk, linux-kernel,
Alexander Stein
Quoting Alexander Stein (2025-08-25 07:08:11)
> From: Matthias Schiffer <matthias.schiffer@tq-group.com>
>
> As described in AM335x Errata Advisory 1.0.42, WKUP_DEBUGSS_CLKCTRL
> can't be disabled - the clock module will just be stuck in transitioning
> state forever, resulting in the following warning message after the wait
> loop times out:
>
> l3-aon-clkctrl:0000:0: failed to disable
>
> Just add the clock to enable_init_clks, so no attempt is made to disable
> it.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-20 5:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-25 14:08 [PATCH 1/1] clk: ti: am33xx: keep WKUP_DEBUGSS_CLKCTRL enabled Alexander Stein
2025-09-05 21:40 ` Kevin Hilman
2025-09-20 5:27 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).