From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, agross@kernel.org, marc.w.gonzalez@free.fr,
david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc
Date: Wed, 1 May 2019 08:17:09 -0600 [thread overview]
Message-ID: <807e0789-6a7d-28b5-2811-df8e7e4ae393@codeaurora.org> (raw)
In-Reply-To: <20190501033430.GB2938@tuxbook-pro>
On 4/30/2019 9:34 PM, Bjorn Andersson wrote:
> On Tue 30 Apr 19:24 PDT 2019, Jeffrey Hugo wrote:
>
>> The global clock controller on MSM8998 can consume a number of external
>> clocks. Document them.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/clock/qcom,gcc.txt | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.txt b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
>> index 8661c3c..7d45323 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.txt
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
>> @@ -28,6 +28,16 @@ Required properties :
>> - #clock-cells : shall contain 1
>> - #reset-cells : shall contain 1
>>
>> +For MSM8998 only:
>> + - clocks: a list of phandles and clock-specifier pairs,
>> + one for each entry in clock-names.
>> + - clock-names: "xo" (required)
>> + "usb3_pipe" (optional)
>> + "ufs_rx_symbol0" (optional)
>> + "ufs_rx_symbol1" (optional)
>> + "ufs_tx_symbol0" (optional)
>> + "pcie0_pipe" (optional)
>
> The optional clocks here comes from hardware blocks that in turn depends
> on the gcc, so we would need to resolve them lazily (in contrast to xo).
>
> We typically don't list these in DT, but if this is close to the
> complete list of incoming clocks then I like the explicitness of it.
I reviewed the hardware documentation, and this is a complete list,
except for some "aud_ref_clk" which I can't tell exactly where it comes
from, and I see no use for it. As near as I can tell, this list should
cover all the needs going forward.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
>> +
>> Optional properties :
>> - #power-domain-cells : shall contain 1
>> - Qualcomm TSENS (thermal sensor device) on some devices can
>> --
>> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
>> Qualcomm Technologies, Inc. is a member of the
>> Code Aurora Forum, a Linux Foundation Collaborative Project.
>>
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-05-01 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 2:23 [PATCH v3 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-05-01 2:24 ` [PATCH v3 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-05-01 3:34 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo [this message]
2019-05-01 19:48 ` Rob Herring
2019-05-01 2:25 ` [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-05-01 3:35 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo
2019-05-01 2:26 ` [PATCH v3 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-05-01 3:26 ` Bjorn Andersson
2019-05-01 2:26 ` [PATCH v3 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-05-01 3:37 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-05-01 3:43 ` Bjorn Andersson
2019-05-01 14:25 ` Jeffrey Hugo
2019-05-01 16:54 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-05-01 3:44 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=807e0789-6a7d-28b5-2811-df8e7e4ae393@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox