From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dylan Hung <dylan_hung@aspeedtech.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: BMC-SW@aspeedtech.com
Subject: Re: [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions
Date: Wed, 21 Jun 2023 12:11:11 +0200 [thread overview]
Message-ID: <80cd8bb9-54ad-4c5c-f3ce-c8655cd2ff74@linaro.org> (raw)
In-Reply-To: <20230621094545.707-1-dylan_hung@aspeedtech.com>
On 21/06/2023 11:45, Dylan Hung wrote:
> Add reset definitions of AST2600 I3C and MAC controllers.
>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
> ---
> include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index e149eee61588..07377589f8f4 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -90,7 +90,18 @@
> /* Only list resets here that are not part of a clock gate + reset pair */
> #define ASPEED_RESET_ADC 55
> #define ASPEED_RESET_JTAG_MASTER2 54
> -#define ASPEED_RESET_I3C_DMA 39
This will break all the users.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-21 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:45 [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions Dylan Hung
2023-06-21 10:11 ` Krzysztof Kozlowski [this message]
2023-06-30 6:12 ` Dylan Hung
2023-06-30 6:16 ` Dylan Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80cd8bb9-54ad-4c5c-f3ce-c8655cd2ff74@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=BMC-SW@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox