Re: [PATCH v8 02/10] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller

[Taniya Das <quic_tdas@quicinc.com>]

On 4/28/2025 6:38 PM, Vladimir Zapolskiy wrote:
> Hi Taniya.
> 
> On 4/24/25 12:32, Taniya Das wrote:
>> Add DT bindings for the Camera clock on QCS615 platforms. Add the
>> relevant DT include definitions as well.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>>   .../bindings/clock/qcom,qcs615-camcc.yaml          |  43 ++++++++
>>   include/dt-bindings/clock/qcom,qcs615-camcc.h      | 110 +++++++++++
>> ++++++++++
>>   2 files changed, 153 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs615-
>> camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs615-
>> camcc.yaml
>> new file mode 100644
>> index
>> 0000000000000000000000000000000000000000..2b811e66d406c16c70004bb3a9fce294422a5914
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,qcs615-camcc.yaml
>> @@ -0,0 +1,43 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,qcs615-camcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Camera Clock & Reset Controller on QCS615
>> +
>> +maintainers:
>> +  - Taniya Das <quic_tdas@quicinc.com>
>> +
>> +description: |
>> +  Qualcomm camera clock control module provides the clocks, resets
>> and power
>> +  domains on QCS615.
>> +
>> +  See also: include/dt-bindings/clock/qcom,qcs615-camcc.h
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,qcs615-camcc
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
>> +
>> +allOf:
>> +  - $ref: qcom,gcc.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/qcom,rpmh.h>
>> +    clock-controller@ad00000 {
>> +      compatible = "qcom,qcs615-camcc";
>> +      reg = <0xad00000 0x10000>;
>> +      clocks = <&rpmhcc RPMH_CXO_CLK>;
>> +
>> +      #clock-cells = <1>;
>> +      #reset-cells = <1>;
>> +      #power-domain-cells = <1>;
>> +    };
>> +...
> 
> Is there anything what prevents to add this clock controller dt bindings
> description into qcom,sm6350-camcc.yaml ?
> 
> Apart of compatible values I barely see any difference between two of them.
> 

Sure, I can re-use the bindings and push the next patch.


> -- 
> Best wishes,
> Vladimir