Re: [PATCH 2/4] soc: toshiba: tc9564: add a new syscon driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 04/11/2026 01:43, Alex Elder wrote:
> Introduce a new system controller driver for devices found within the
> Toshiba TC9564 SoC.  The system controller manages access to an 8 KB
> region, and implements controllers for a set of clocks as well as a
> set of resets.  The region also includes registers that indicate when
> initialization is done for the chip's two Ethernet interfaces.
> 
> The SoC has a single 25 MHz input clock, and from that derives clocks
> of various rates used by functional blocks within the chip.
> 
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
>  MAINTAINERS                         |  1 +
>  drivers/soc/Kconfig                 |  1 +
>  drivers/soc/Makefile                |  1 +
>  drivers/soc/toshiba/Kconfig         | 12 +++++++++
>  drivers/soc/toshiba/Makefile        |  3 +++
>  drivers/soc/toshiba/tc9564-syscon.c | 42 +++++++++++++++++++++++++++++
>  6 files changed, 60 insertions(+)
>  create mode 100644 drivers/soc/toshiba/Kconfig
>  create mode 100644 drivers/soc/toshiba/Makefile
>  create mode 100644 drivers/soc/toshiba/tc9564-syscon.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2b1b29169e0e9..c25ee6e0f1c68 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -28345,6 +28345,7 @@ M:	Alex Elder <elder@kernel.org>
>  M:	Daniel Thompson <danielt@kernel.org>
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml
> +F:	drivers/soc/toshiba/tc9564-syscon.c

No, this has to stop. There IS NO TOSHIBA SOC here, how we understand SoC.

drivers/soc/ are ONLY for SoCs running Linux, not for regular devices,
which you are describing here. You have standard PCI device, not
drivers/soc/

And if this was Toshiba SoC, you did not even Cc Toshiba maintainer.

Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


Best regards,
Krzysztof