Re: [PATCH 4/4] clk: qcom: gcc: Add support for Global Clock controller found on SDM439

Konrad Dybcio
2025-11-17T12:40:35Z

On 11/16/25 10:35 PM, Barnabás Czémán wrote:
> From: Lanik <daniilt971@gmail.com>
>
> Modify existing MSM8917 driver to support SDM439 SoC. SDM439 SoC has the
> same changes as MSM8937 SoC, but with different gpll3 vco rate and
> different GFX3D clock frequency table.
>
> Signed-off-by: Lanik <daniilt971@gmail.com>

This doesn't seem like a proper full name, please fix up your git
config

[...]

> +static void sdm439_clock_override(void)
> +{
> + /*
> + * Set below clocks for use specific sdm439 parent map.
> + */
> + vcodec0_clk_src.parent_map = gcc_cpp_map;
> + vcodec0_clk_src.clkr.hw.init = &vcodec0_clk_src_init_msm8937;
> +
> + /*
> + * Set below clocks for use specific sdm439 freq table.
> + */

These comments are rather self-explanatory, you can drop them

Konrad