From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28E3C43387 for ; Fri, 18 Jan 2019 14:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB8AF2087E for ; Fri, 18 Jan 2019 14:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727241AbfAROQj (ORCPT ); Fri, 18 Jan 2019 09:16:39 -0500 Received: from mail.bootlin.com ([62.4.15.54]:44704 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727178AbfAROQj (ORCPT ); Fri, 18 Jan 2019 09:16:39 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id CFA92207B0; Fri, 18 Jan 2019 15:16:36 +0100 (CET) Received: from localhost (alyon-652-1-26-46.w109-213.abo.wanadoo.fr [109.213.9.46]) by mail.bootlin.com (Postfix) with ESMTPSA id 703E52074A; Fri, 18 Jan 2019 15:16:36 +0100 (CET) From: Gregory CLEMENT To: Miquel Raynal Cc: Michael Turquette , Stephen Boyd , Russell King , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Antoine Tenart , Maxime Chevallier , Nadav Haklai Subject: Re: [PATCH v4 3/4] clk: mvebu: armada-37xx-tbg: fill the device entry when registering the clocks References: <20190108161940.4814-1-miquel.raynal@bootlin.com> <20190108161940.4814-4-miquel.raynal@bootlin.com> Date: Fri, 18 Jan 2019 15:16:36 +0100 In-Reply-To: <20190108161940.4814-4-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Tue, 8 Jan 2019 17:19:39 +0100") Message-ID: <871s5anj97.fsf@FE-laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Miquel, On mar., janv. 08 2019, Miquel Raynal wrote: > So far the clk_hw_register_fixed_factor() calls are not providing any > device structure. While doing so is harmless for regular use, the > missing device structure may be a problem for suspend to RAM support. > > Since, device links have been added to clocks, links created during > probe will enforce the suspend/resume orders. When the device is > missing during the registration, no link can be established, hence the > order between parent and child clocks are not enforced. > > Adding the device structure here will create a link between the 4 TBG > clocks (registered by this driver) and: > * their parent clock: XTAL, > * their child clocks: several 'periph' clock. > > Signed-off-by: Miquel Raynal Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/clk/mvebu/armada-37xx-tbg.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/mvebu/armada-37xx-tbg.c b/drivers/clk/mvebu/armada-37xx-tbg.c > index 77b978c55ef6..da3a08e419d6 100644 > --- a/drivers/clk/mvebu/armada-37xx-tbg.c > +++ b/drivers/clk/mvebu/armada-37xx-tbg.c > @@ -116,8 +116,10 @@ static int armada_3700_tbg_clock_probe(struct platform_device *pdev) > name = tbg[i].name; > mult = tbg_get_mult(reg, &tbg[i]); > div = tbg_get_div(reg, &tbg[i]); > - hw_tbg_data->hws[i] = clk_hw_register_fixed_factor(NULL, name, > - parent_name, 0, mult, div); > + hw_tbg_data->hws[i] = clk_hw_register_fixed_factor(dev, name, > + parent_name, > + 0, mult, > + div); > if (IS_ERR(hw_tbg_data->hws[i])) > dev_err(dev, "Can't register TBG clock %s\n", name); > } > -- > 2.19.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com