From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH v2] clk: pxa: pxa3xx: fix CKEN register access
Date: Sat, 08 Aug 2015 09:34:44 +0200 [thread overview]
Message-ID: <87614qkzcb.fsf@belgarion.home> (raw)
In-Reply-To: <20150807235515.GF16477@codeaurora.org> (Stephen Boyd's message of "Fri, 7 Aug 2015 16:55:15 -0700")
Stephen Boyd <sboyd@codeaurora.org> writes:
> On 08/04, Robert Jarzmik wrote:
>> Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names
>> were inadequately inverted. As a consequence, all clock operations were
>> happening on CKENB, because almost all but 2 clocks are on CKENA.
>>
>> As the clocks were activated by the bootloader in the former tests, it
>> escaped the testing that the wrong clock gate was manipulated. The error
>> was revealed by changing the pxa3xx-and driver to a module, where tupon
>> unloading the wrong clock was disabled in CKENB.
>>
>> Fixes: 9bbb8a338fb2 ("clk: pxa: add pxa3xx clock driver")
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> ---
>
> Applied to clk-fixes. Sorry, got busy last few days.
Thanks Stephen !
Cheers.
--
Robert
prev parent reply other threads:[~2015-08-08 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 6:21 [PATCH v2] clk: pxa: pxa3xx: fix CKEN register access Robert Jarzmik
2015-08-07 23:55 ` Stephen Boyd
2015-08-08 7:34 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87614qkzcb.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox