Re: [PATCH 00/16] Add support for Inside-Secure EIP-150 crypto block

Miquel Raynal
2026-04-01T09:02:17Z

Hi Geert,

On 30/03/2026 at 15:33:30 +02, Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Miquel,
>
> On Fri, 27 Mar 2026 at 21:10, Miquel Raynal (Schneider Electric)
> <miquel.raynal@bootlin.com> wrote:
>> This is a series adding support for the EIP-150, which is a crypto block
>> containing:
>> - a public key accelerator
>> - a random number generator
>> - an interrupt controller
>
> Thanks for your series!
>
>> irqchip/eip201-aic: Add support for Safexcel EIP-201 AIC
> [...]
>> crypto: eip28: Add support for SafeXcel EIP-28 Public Key Accelerator
>
> My OCD tells me to ask for using "SafeXcel" consistently, ;-)

Ah, yeah :) I initially wrote "Safexcel" everywhere, and at some point I
realized the marketing department had put a capital letter in the middle
of the word. My anti kamel-case heart fought back, but not enough, ending
up with a mix of both.

> drivers/crypto/inside-secure/eip28.c: .name = "Safexcel EIP28 PKA",
> drivers/irqchip/Kconfig: tristate "Safexcel EIP201 AIC"
> drivers/irqchip/Kconfig: inside Safexcel EIP150 IPs, gathering
> Public Key Accelerator

I'll address these.

Thanks,
Miquèl