Linux clock framework development
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: sashiko-bot@kernel.org,  sashiko-reviews@lists.linux.dev,
	linux-clk@vger.kernel.org,  devicetree@vger.kernel.org,
	 robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 04/10] clk: nuvoton: ma35d1: Reparent the gates correctly
Date: Mon, 19 Oct 2026 11:55:43 +0200	[thread overview]
Message-ID: <87cxt6ypy8.fsf@bootlin.com> (raw)
In-Reply-To: <179224878757.859276.836775392883899374.b4-reply@b4> (Jerome Brunet's message of "Sat, 17 Oct 2026 16:53:07 +0200")

On 17/10/2026 at 16:53:07 +02, Jerome Brunet <jbrunet@baylibre.com> wrote:

> On 2026-10-15 18:50:54+02:00, Miquel Raynal wrote:
>> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>> > - [Medium] clk: nuvoton: CCAP muxes registered with 1-bit width but 4
>> > parents
>> 
>> This is a pre-existing issue. I will wait for the maintainers to comment
>> on the rest of the series. If they ask for other changes, I'll include
>> this to the next revision. If not, I will send a dedicated patch for it.
>
> It is too late for cycle for this cycle and I'll wait for rc1.

I understand your reluctance, but in case you delay the clk PR or make a
second PR during this merge window I'd like to stress the fact that the
very first patch of this series is actually fixing the probe of the SPI
controller on the Nuvoton platform. The rest is general improvement
which makes sense to merge after -rc1 at this point, but in case there
is still a window, I believe from a maintainance standpoing it makes
sense to take it.

> Best would be sent the next versions without the DT stuff, so we can apply
> the series using the cover as merge description . It makes it easier for
> us to then provide an immutable branch, should you need it for the DT
> side.

I don't know what is the canonical way, but myself when I apply series
with patches that do not belong to 'my' subsystem (typically DT patches)
I do apply the whole series using b4 using the cover letter and then
just `git reset --hard <before the DT stuff>`. When sending the `ty`
letters, it just states something like "<no commit>" under the said DT
patches, which is perfectly fine. Most maintainers seem to just do that
given the various `ty` letters I receive when I am the contributor.

> You can fold pre-existing issue fixups in your series if you want to,
> or you can send follow-ups later. Fine with me either way.

Since I will re-send it at -rc1, I will include that extra fix.

Thanks,
Miquèl

  reply	other threads:[~2026-10-19  9:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 16:01 [PATCH v10 00/10] clk: nuvoton: ma35d1: Fix mux parenting and peripheral clock rates Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 01/10] clk: nuvoton: ma35d1: Use clk_hw pointers as mux parents Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 02/10] clk: nuvoton: ma35d1: Avoid possible error pointer dereferencing Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 03/10] clk: nuvoton: ma35d1: Retrieve HXT/LXT from DT when possible Miquel Raynal
2026-10-17 14:53   ` Jerome Brunet
2026-10-19  8:13     ` Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 04/10] clk: nuvoton: ma35d1: Reparent the gates correctly Miquel Raynal
2026-10-15 16:16   ` sashiko-bot
2026-10-15 16:50     ` Miquel Raynal
2026-10-17 14:53       ` Jerome Brunet
2026-10-19  9:55         ` Miquel Raynal [this message]
2026-10-15 16:01 ` [PATCH v10 05/10] clk: nuvoton: ma35d1: Use device managed helpers for fixed rate clocks Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 06/10] clk: Create devm_clk_hw_register_fixed_rate_parent_hw() Miquel Raynal
2026-10-17 14:53   ` Jerome Brunet
2026-10-15 16:01 ` [PATCH v10 07/10] clk: nuvoton: ma35d1: Reparent SYSPLL correctly Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 08/10] MAINTAINERS: Add myself as Nuvoton MA35D1 clock controller Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 09/10] arm64: dts: nuvoton: ma35d1: Drop HXT clock output name Miquel Raynal
2026-10-15 16:01 ` [PATCH v10 10/10] arm64: dts: nuvoton: ma35d1: Add LXT crystal and clock-names Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxt6ypy8.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox