From: Andreas Schwab <schwab@linux-m68k.org>
To: Zong Li <zong.li@sifive.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, lee.jones@linaro.org,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/1] clk: sifive: Fix W=1 kernel build warning
Date: Wed, 08 Dec 2021 09:31:18 +0100 [thread overview]
Message-ID: <87pmq7qyzt.fsf@igel.home> (raw)
In-Reply-To: <d2e681e5ea31c62529b619a3777570b4792e0684.1638928796.git.zong.li@sifive.com> (Zong Li's message of "Wed, 8 Dec 2021 10:04:22 +0800")
On Dez 08 2021, Zong Li wrote:
> diff --git a/drivers/clk/sifive/fu540-prci.h b/drivers/clk/sifive/fu540-prci.h
> index c220677dc010..c8271efa7bdc 100644
> --- a/drivers/clk/sifive/fu540-prci.h
> +++ b/drivers/clk/sifive/fu540-prci.h
> @@ -13,4 +13,9 @@
>
> extern struct __prci_clock __prci_init_clocks_fu540[NUM_CLOCK_FU540];
>
> +static const struct prci_clk_desc prci_clk_fu540 = {
> + .clks = __prci_init_clocks_fu540,
> + .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540),
> +};
> +
A header should only declare things, not define them.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-12-08 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 2:04 [PATCH 1/1] clk: sifive: Fix W=1 kernel build warning Zong Li
2021-12-08 8:31 ` Andreas Schwab [this message]
2021-12-08 9:22 ` Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmq7qyzt.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sboyd@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox