From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCF2CA9EC5 for ; Wed, 30 Oct 2019 20:57:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56EA720873 for ; Wed, 30 Oct 2019 20:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbfJ3U5R (ORCPT ); Wed, 30 Oct 2019 16:57:17 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:44923 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbfJ3U5R (ORCPT ); Wed, 30 Oct 2019 16:57:17 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d15 with ME id KwxF210025TFNlm03wxFig; Wed, 30 Oct 2019 21:57:15 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 30 Oct 2019 21:57:15 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org Subject: Re: [PATCH 36/46] ARM: pxa: move smemc register access from clk to platform References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-36-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 30 Oct 2019 21:57:15 +0100 In-Reply-To: <20191018154201.1276638-36-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:51 +0200") Message-ID: <87pnielzo4.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Arnd Bergmann writes: > The get_sdram_rows() and get_memclkdiv() helpers need smemc > register that are separate from the clk registers, move > them out of the clk driver, and use an extern declaration > instead. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Signed-off-by: Arnd Bergmann This patch bothers me a bit. The idea behind generic.c is that it's a file common to all pxa2xx, pxa3xx platforms. Yet with this patch, someone without history will believe that calling pxa_smemc_get_sdram_rows() on a pxa3xx platform is perfectly valid, while it is not, because DRAC2 doesn't exist on pxa3xx (bits are not defined in MDCNFG). At least I'll rename the function to pxa2xx_smemc_get_sdram_rows() if you don't have a better idea. Cheers. -- Robert