Re: [PATCH v2 3/6] clk: sunxi-ng: nkm: Support minimum and maximum rate

Maxime Ripard
2024-02-22T10:28:05Z

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Wed, Feb 21, 2024 at 11:38:39AM +0100, Frank Oltmanns wrote:
> Hi Jernej,
> hi Maxime,
>
> On 2024-02-05 at 16:22:26 +0100, Frank Oltmanns <frank@oltmanns.dev> wrote:
> > According to the Allwinner User Manual, the Allwinner A64 requires
> > PLL-MIPI to run at 500MHz-1.4GHz. Add support for that to ccu_nkm.
>
> I should point out that limiting PLL-MIPI also fixes a regression
> that was introduced in 6.5, specifically
> ca1170b69968233b34d26432245eddf7d265186b "clk: sunxi-ng: a64: force
> select PLL_MIPI in TCON0 mux". This has been bisected and reported by
> Diego [1].
>
> I don't know the procedure (yet), but probably the fix (if and when
> accepted) should be backported at least to 6.6 (first broken LTS), 6.7
> (stable), and 6.8 (next stable).

https://www.kernel.org/doc/html/next/process/stable-kernel-rules.html#procedure-for-submitting-patches-to-the-stable-tree

> My suggestion:
> - In V3 of this series, I will reorder the patches, so that what is now
> PATCH 3 and 4 becomes 1 and 2 respectively, so that they can be
> applied to 6.6 more easily.
> - Maxime, IIUC you requested some refactoring for handling the rate
> limits [2]. I propose, we use my current proposal as-is, and I will
> do a follow-up series for the refactoring.

I'd really like to not introduce a new ad-hoc implementation of range
handling. It's fine for older users to not be converted yet, but we
shouldn't introduce more users.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]