From: Eric Anholt <eric@anholt.net>
To: Danilo Krummrich <danilokrummrich@dk-develop.de>,
rjui@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
stefan.wahren@i2se.com, linux-rpi-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, sboyd@codeaurora.org
Subject: Re: [PATCH] clk: bcm2835: remove remains from stub clk driver
Date: Mon, 05 Jun 2017 10:34:56 -0700 [thread overview]
Message-ID: <87y3t6xrr3.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170605121933.25288-1-danilokrummrich@dk-develop.de>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
Danilo Krummrich <danilokrummrich@dk-develop.de> writes:
> This commit removes the fixed clocks introduced as a stub clock driver
> added with commit 75fabc3f6448 ("ARM: bcm2835: add stub clock driver").
> Originally they were used to drive the AMBA bus and PL011 uart driver.
> Now these clocks are derived by the CPRMAN clock driver and configured
> in DT.
>
> Additionally, get rid of init_machine function in bcm2835 board file
> as there's nothing to do any longer.
>
> Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
This technically breaks loading a new kernel with an ancient DT.
However, in the Raspberry Pi world, the DT and kernel are always shipped
together, because the DT (even in the downstream firmware package) is
built out of the linux kernel tree and shipped alongside the kernel.
If the clock maintainers are OK with picking this, it's:
Acked-by: Eric Anholt <eric@anholt.net>
and I'm pretty sure it won't conflict with anything we've got going on
in arm/.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-06-05 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 12:19 [PATCH] clk: bcm2835: remove remains from stub clk driver Danilo Krummrich
2017-06-05 17:34 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3t6xrr3.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=danilokrummrich@dk-develop.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sboyd@codeaurora.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox