From: Stephen Boyd <sboyd@kernel.org>
To: Lubomir Rintel <lrintel@redhat.com>, linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Lubomir Rintel <lkundrak@v3.sk>,
stable@vger.kernel.org
Subject: Re: [PATCH] clk: mmp2: call pm_genpd_init() only after genpd.name is set
Date: Tue, 07 Jan 2025 13:37:49 -0800 [thread overview]
Message-ID: <899f7dc2cea70fa6bfc22ad08354ec98.sboyd@kernel.org> (raw)
In-Reply-To: <20241231190336.423172-1-lkundrak@v3.sk>
Quoting Lubomir Rintel (2024-12-31 11:03:35)
> Setting the genpd's struct device's name with dev_set_name() is
> happening within pm_genpd_init(). If it remains NULL, things can blow up
> later, such as when crafting the devfs hierarchy for the power domain:
>
> 8<--- cut here --- [please do not actually cut, you'll ruin your display]
> Unable to handle kernel NULL pointer dereference at virtual address 00000000 when read
> ...
> Call trace:
> strlen from start_creating+0x90/0x138
> start_creating from debugfs_create_dir+0x20/0x178
> debugfs_create_dir from genpd_debug_add.part.0+0x4c/0x144
> genpd_debug_add.part.0 from genpd_debug_init+0x74/0x90
> genpd_debug_init from do_one_initcall+0x5c/0x244
> do_one_initcall from kernel_init_freeable+0x19c/0x1f4
> kernel_init_freeable from kernel_init+0x1c/0x12c
> kernel_init from ret_from_fork+0x14/0x28
>
> Bisecting tracks this crash back to commit 899f44531fe6 ("pmdomain: core:
> Add GENPD_FLAG_DEV_NAME_FW flag"), which exchanges use of genpd->name
> with dev_name(&genpd->dev) in genpd_debug_add.part().
>
> Fixes: 899f44531fe6 ("pmdomain: core: Add GENPD_FLAG_DEV_NAME_FW flag")
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Please tell me which author domain it is supposed to be. redhat.com or
v3.sk?
next prev parent reply other threads:[~2025-01-07 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 19:03 [PATCH] clk: mmp2: call pm_genpd_init() only after genpd.name is set Lubomir Rintel
2025-01-07 21:36 ` Stephen Boyd
2025-01-07 21:37 ` Stephen Boyd [this message]
2025-01-08 12:24 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=899f7dc2cea70fa6bfc22ad08354ec98.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=lrintel@redhat.com \
--cc=mturquette@baylibre.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox