From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A95C07E85 for ; Fri, 7 Dec 2018 15:13:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C16020837 for ; Fri, 7 Dec 2018 15:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Njdm2dQw"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Dt7O+XU2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C16020837 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-clk-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726041AbeLGPNU (ORCPT ); Fri, 7 Dec 2018 10:13:20 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51820 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbeLGPNU (ORCPT ); Fri, 7 Dec 2018 10:13:20 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id BA5A260792; Fri, 7 Dec 2018 15:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544195598; bh=+mqfN/8Qh8/QyieDtTmNvFLM604n5M1874yB0KutcYQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Njdm2dQw7/lLEe39CP22i4CcsFUfBKRD3l6C/6o3ug5riEBbm9unWwQLQrfUnasgk k0cP5KK4ZJc1ZWDgK/IAIDd9NAspdTtp2hyqYP93fP8Tp22kUBRzShvFm+HtxexKIi hTVyyoPXyGgqXUHazpLLaxIMuPIv/oXtcjjCtkJ8= Received: from [10.226.60.81] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3DE4C601C4; Fri, 7 Dec 2018 15:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544195597; bh=+mqfN/8Qh8/QyieDtTmNvFLM604n5M1874yB0KutcYQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Dt7O+XU2fHyCiiSkuspgC1xThGI/7GyYn01YVZfMFiE+gPl3nJ0TyWH9aYmHpy07m a/iohbIZmZnyy+SkRgvjb4mm06V4aLsXo/Yg5piMk2dxMnSIO1hQeYi+v5sBf4A9cs OA3pvH2M+9FygTmP3U3DyYmp/UysjR0Kk1Yto4tg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3DE4C601C4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v2] clk: qcom: smd: Add support for MSM8998 rpm clocks To: Marc Gonzalez , Michael Turquette , Stephen Boyd Cc: Bjorn Andersson , linux-clk , MSM , LKML References: <1544134310-10227-1-git-send-email-jhugo@codeaurora.org> <84c0fd53-98e9-ac41-f1ca-68ad6d676e9a@free.fr> From: Jeffrey Hugo Message-ID: <8b3702e8-3779-db5c-1777-94a6d97c1080@codeaurora.org> Date: Fri, 7 Dec 2018 08:13:16 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <84c0fd53-98e9-ac41-f1ca-68ad6d676e9a@free.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 12/7/2018 7:23 AM, Marc Gonzalez wrote: > On 06/12/2018 23:11, Jeffrey Hugo wrote: > >> Add rpm smd clocks, PMIC and bus clocks which are required on MSM8998 >> for clients to vote on. >> >> Signed-off-by: Jeffrey Hugo >> --- >> v2 >> -fix compatible ordering nits per Stephen >> >> .../devicetree/bindings/clock/qcom,rpmcc.txt | 1 + >> drivers/clk/qcom/clk-smd-rpm.c | 62 ++++++++++++++++++++++ >> include/dt-bindings/clock/qcom,rpmcc.h | 6 +++ >> 3 files changed, 69 insertions(+) > > Hmmm, my board seems to dislike this patch... it locks up for a while, > then reboots. > > [ 6.957289] ufshcd-qcom 1da4000.ufshc: ufshcd_query_flag: Sending flag query for idn 1 failed, err = -11 > [ 6.961233] ufshcd-qcom 1da4000.ufshc: ufshcd_query_flag_retry: failed with error -11, retries 2 > [ 6.970782] ufshcd-qcom 1da4000.ufshc: ufshcd_query_flag_retry: query attribute, opcode 6, idn 1, failed with error -11 after 3 retires > [ 6.979576] ufshcd-qcom 1da4000.ufshc: ufshcd_complete_dev_init setting fDeviceInit flag failed with error -11 > [ 23.432798] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks: > [ 23.432884] rcu: 7-...0: (1 GPs behind) idle=6a2/1/0x4000000000000000 softirq=92/93 fqs=2626 > [ 23.437927] rcu: (detected by 0, t=5252 jiffies, g=-819, q=112) > [ 23.446425] Task dump for CPU 7: > [ 23.452567] swapper/0 R running task 0 1 0 0x0000002a > [ 23.455806] Call trace: > [ 23.462872] __switch_to+0x94/0xe0 > [ 23.465009] _regmap_write+0x58/0xb0 > [ 23.468452] _regmap_update_bits+0xf0/0x110 > [ 23.472186] regmap_update_bits_base+0x60/0x90 > [ 23.476110] clk_disable_regmap+0x34/0x40 > [ 23.480614] clk_branch_toggle+0x108/0x1b0 > [ 23.484681] clk_branch2_disable+0x18/0x20 > [ 23.488692] clk_disable_unused_subtree+0xc4/0xe0 > [ 23.492761] clk_disable_unused+0x3c/0x130 > [ 23.497535] do_one_initcall+0x5c/0x180 > [ 23.501557] kernel_init_freeable+0x198/0x244 > [ 23.505276] kernel_init+0x10/0x110 > [ 23.509768] ret_from_fork+0x10/0x20 > > /*** REBOOT ***/ > Format: Log Type - Time(microsec) - Message - Optional Info > Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic > > I need to check the ufs_reset pin and phy init seq before I can investigate > this issue, but I wanted to send a report ASAP. > Hmm. I run with clk_ignore_unused. I'm guessing that something was defined that should be used eventually, but isn't used now, and so its getting turned off when it probably shouldn't be. I'll try to repro on my end. -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.