From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed2-f30.google.com (mail-ed2-f30.google.com [74.125.228.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7015D4FECE7 for ; Thu, 17 Sep 2026 12:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.94 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648335; cv=none; b=DTlWgWFNfjnEHp0U+6ODw59ER6ESmoKjEmlod7ZYiLVeCMcXipMoA2f+SggAE6Rlma8tq6MRc49BIH3L69RzCI69FnxHm+AbtIBtcw94aEMJO8jbmhpZNvvYCak+aHeo/MqG4UdsqybvvwMxaL+ijJIurzvor3++CZ3SrI6FrKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789648335; c=relaxed/simple; bh=3w1QO9RRjV2P//77/vuGY3t+8liMQZidimN+GXQ/Shw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uzGojhoVROZR2NetlNwObhGn3dBf8hal4JK5qw3ssi23oGSFhnoJQ8GcPPxD5Rr7m6x8IszplBbfggLeUSFDSNttPBv410T7I8UhJGWFAhZPSjFwA7Hkaa1IaV8/Ij1slGXxwt8xkyNOKcLDHhuodXnGs4g0TcJQ1Hme//B3qUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e/fiuBNL; arc=none smtp.client-ip=74.125.228.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e/fiuBNL" Received: by mail-ed2-f30.google.com with SMTP id 4fb4d7f45d1cf-6aa06e51bc3so1368991a12.2 for ; Thu, 17 Sep 2026 05:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789648323; x=1790253123; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ls/PIdXgwRaJNqkytOniziANCA/o27n7uKp1MTR7az8=; b=e/fiuBNLG4E9oZeVsqDRZUNO6JWwxgCRIyimmkUghYQJnr2LhxsdxwaEvvpCdtStT9 u0Cz2Xeowdpk7x0SKOZbSgxmJN46MGJE+ZFeQA4S0wBM2uZZOay4bh6EJXPcol3DYd18 3R5++iHttO7Zp/N0uoYJpa1OgoCbiUlY910aXYyOd9O+/k2FigozCEmn99+I4rxW16Pm 5jJb2ROGGdfsyeOU0SbAxG1m5vwxLm5/2LltsV+9RpfJ0C0ZHu8hdflC1XRtfZsm4NDl FSGDOB+UXLIQ9DORzJDy5aF0EkLB7fkm27qqdP9LAku2yBqxmD0HhyPYTiLjfpMu831F vkxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789648323; x=1790253123; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ls/PIdXgwRaJNqkytOniziANCA/o27n7uKp1MTR7az8=; b=xflbU7MJswvxrRW3vdjudw/h221AwCROU4x5k0GsUnKA4TGaquRzMtgUJdarGu3Yhm lDhrhhffVpr3CHpx9FNG4WdERsSxGJ3BzTkpxImwrSoi7txMtVSLbW5QLL+djPdZ7uRc QmQAevj4vOx1YJAigSnbxz2TUztImqEijaXVsr3FeuP9ipmPcVbQPl+H6atwi55oFKYz 9qrZfndFj8eJsQDr6dEPeVIZZ5en39NQ0W6fQMz2mpBLUZuuoWmOe/Ix3a+rJYR9kty9 Q/s4dOSdBFfOOhd23D5hPakkLrtzddER2dB289/YrpK0dLZzzYTYjH2sHhJkImfaUeVk ueiA== X-Forwarded-Encrypted: i=1; AKwUvByvEIXT4WVr11lWv1ypPqyGaA9nAMM/hLqz2muBn0Ylb+SiuklzzZPXO87/XrunP060+PXiUweewJ8=@vger.kernel.org X-Gm-Message-State: AFuF++no3flP1owdtxb5B+KK4Ztwp2ugjjrnGEpCLWDd43w/NErlLCtS 2AkZfcEaQ6JpfAvyMCM3WSvDDkiyojC7uxiVt0ukr93g3WnJrD3SpUd1HguO+w5EQEc= X-Gm-Gg: AYBFou13I6KXHQNMh0mrSr+olvI7cR6z4sh2ytQCqWy4mtl0Hod0i3GYWOWSPpD+dwn CFmzuyjJwNaRLBRAsR2c8OWEHjm6E5EM5h24eiydNtGamYYW8gOyEHOr9tPtw1HDlnGunq79qG2 C7d8pVXlPjhrK9TUtsDLc79KblKLZNVvU7CLkBGVHoi1bIj21t8jo8QqHenYETIruwKN+mIDPdW Q6vozlekzCFeJgGEPUvdMrJc3nds70UVmXhrvgUa0PzSbnIyto0ST7CkHULC++arCz+o/oVDlfv GPG3sQnoLNQjQmyPY7d6yZrWHCRFKRdWnzn6NIzmqondXCAnqyw8VF57AOHIqSFQiqxXRyEnslw VBFrLWJvoDJqUP1FSAYDIJojCIAq2BDpqr6xunA1f5XK7FXX4np7ih9Pxsxeq2pk02TE9qTgmhL 6qNGGb0ow0HpTATifgUs+B7fuiaPdqb1lckwdiqQr9Q8ERh4q5JI0Wbyu+KnkaiwIA+65eNQZIA Cej/MoQbxA= X-Received: by 2002:a05:6402:3242:b0:6a7:f25b:d281 with SMTP id 4fb4d7f45d1cf-6aa22383344mr3922846a12.13.1789648323558; Thu, 17 Sep 2026 05:32:03 -0700 (PDT) Received: from [192.168.0.167] ([109.76.29.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aa1d2ab4ebsm3576964a12.30.2026.09.17.05.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2026 05:32:03 -0700 (PDT) Message-ID: <8bed3f8f-52dd-4ab7-9ce2-cc756724893d@linaro.org> Date: Thu, 17 Sep 2026 13:32:01 +0100 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v18 2/5] phy: core: Add phy_get_by_of_node() To: Neil Armstrong , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue , Loic Poulain , Vinod Koul , Greg Kroah-Hartman , Kishon Vijay Abraham I , Felipe Balbi , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, Krzysztof Kozlowski References: <20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v18-0-f85c9103177e@linaro.org> <20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v18-2-f85c9103177e@linaro.org> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/09/2026 13:29, Neil Armstrong wrote: >>   /** >>    * _of_phy_get() - lookup and obtain a reference to a phy by phandle >>    * @np: device_node for which to get the phy >>    * @index: the index of the phy >>    * >> - * Returns the phy associated with the given phandle value, >> - * after getting a refcount to it or -ENODEV if there is no such phy or >> - * -EPROBE_DEFER if there is a phandle to the phy, but the device is >> - * not yet loaded. This function uses of_xlate call back function >> provided >> - * while registering the phy_provider to find the phy instance. >> + * Returns the phy associated with the given phandle value after getting >> + * a refcount to it; -ENODEV if there is no such phy or the phy is >> + * disabled; -EPROBE_DEFER if the phy provider is not yet available. >>    */ > > Why changing the comment here ? You're not supposed to changes the > _of_phy_get() behaviour. I have no real memory of that change probably seemd like a good idea at the time. Will drop --- bod