From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
inki.dae@samsung.com, sw0312.kim@samsung.com,
cw00.choi@samsung.com, jy0922.shim@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH RFC 2/7] clk: samsung: Add definitions of some audio related clocks
Date: Thu, 08 Jun 2017 12:00:58 +0200 [thread overview]
Message-ID: <8c6685fb-e9a2-5c69-722e-8ef1a2e800ff@samsung.com> (raw)
In-Reply-To: <20170422152705.mvnycub4unjlseeq@kozik-lap>
On 04/22/2017 05:27 PM, Krzysztof Kozlowski wrote:
>> MUX(CLK_MOUT_MX_MSPLL_CCORE, "mout_mx_mspll_ccore",
>> mout_mx_mspll_ccore_p, SRC_TOP7, 16, 2),
>> - MUX(0, "mout_mau_epll_clk", mout_mau_epll_clk_5800_p, SRC_TOP7,
>> - 20, 2),
>> + MUX(CLK_MOUT_MAU_EPLL, "mout_mau_epll_clk", mout_mau_epll_clk_5800_p,
>> + SRC_TOP7, 20, 2),
>
> How about not changing the indention level of new line? On the other
> hand, if you want to change it so maybe align it with opening
> parenthesis?
Thanks for your review. I wrote it this way to keep it consistent with
remaining entries of the exynos5800_mux_clks[] array. I think it's less
mess this way, otherwise we would need to make more dubious whitespace
changes to keep the indentation consistent.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2017-06-08 10:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170421172007epcas1p25dba753df34c309e6b00ed08ae930043@epcas1p2.samsung.com>
2017-04-21 17:19 ` [PATCH RFC 0/7] HDMI audio support for Exynos Odroid boards Sylwester Nawrocki
2017-04-21 17:19 ` [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks Sylwester Nawrocki
2017-04-22 2:51 ` Stephen Boyd
2017-04-24 11:12 ` Sylwester Nawrocki
2017-04-22 15:22 ` Krzysztof Kozlowski
2017-04-24 11:12 ` Sylwester Nawrocki
2017-04-24 11:18 ` Krzysztof Kozlowski
2017-04-24 11:35 ` Sylwester Nawrocki
2017-04-24 11:50 ` Krzysztof Kozlowski
2017-04-21 17:19 ` [PATCH RFC 2/7] clk: samsung: Add definitions of some audio related clocks Sylwester Nawrocki
2017-04-22 15:27 ` Krzysztof Kozlowski
2017-06-08 10:00 ` Sylwester Nawrocki [this message]
2017-04-21 17:19 ` [PATCH RFC 3/7] clk: samsung: exynos542x: Add EPLL rate table Sylwester Nawrocki
2017-04-22 15:28 ` Krzysztof Kozlowski
2017-04-21 17:19 ` [PATCH RFC 4/7] drm: exynos: Add driver for HDMI audio interface Sylwester Nawrocki
2017-04-22 15:31 ` Krzysztof Kozlowski
2017-04-21 17:19 ` [PATCH RFC 5/7] ASoC: Add Odroid sound DT bindings documentation Sylwester Nawrocki
2017-04-21 17:28 ` Applied "ASoC: Add Odroid sound DT bindings documentation" to the asoc tree Mark Brown
2017-04-21 17:31 ` Krzysztof Kozlowski
2017-04-21 17:58 ` Mark Brown
2017-04-21 18:01 ` Krzysztof Kozlowski
2017-04-21 18:07 ` Krzysztof Kozlowski
2017-04-24 9:57 ` Mark Brown
2017-04-28 17:03 ` [PATCH RFC 5/7] ASoC: Add Odroid sound DT bindings documentation Rob Herring
2017-06-09 16:53 ` Sylwester Nawrocki
2017-04-21 17:19 ` [PATCH RFC 6/7] ASoC: samsung: Add Odroid ASoC machine driver Sylwester Nawrocki
2017-04-21 17:28 ` Applied "ASoC: samsung: Add Odroid ASoC machine driver" to the asoc tree Mark Brown
2017-04-21 17:19 ` [PATCH RFC 7/7] ARM: dts: samsung: Switch to dedicated Odroid sound card binding Sylwester Nawrocki
2017-04-21 18:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c6685fb-e9a2-5c69-722e-8ef1a2e800ff@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox