public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Nikita Shubin <nikita.shubin@maquefel.me>,
	Nikita Shubin via B4 Relay
	<devnull+nikita.shubin.maquefel.me@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v10 03/38] clk: ep93xx: add DT support for Cirrus EP93xx
Date: Wed, 10 Jul 2024 12:55:11 -0700	[thread overview]
Message-ID: <8e10f0736ea87ed3f7cea4cac506fc24.sboyd@kernel.org> (raw)
In-Reply-To: <7f2bf860ffaccd10899b72fdda6a3ca9c50d2107.camel@maquefel.me>

Quoting Nikita Shubin (2024-07-10 03:34:12)
> On Mon, 2024-07-08 at 15:18 -0700, Stephen Boyd wrote:
> > Quoting Nikita Shubin via B4 Relay (2024-06-17 02:36:37)
> > > diff --git a/drivers/clk/clk-ep93xx.c b/drivers/clk/clk-ep93xx.c
> > > +
> > > +       hw = devm_clk_hw_register_fixed_rate(dev, "pll2", "xtali",
> > > 0, clk_pll2_rate);
> > 
> > Please use clk_parent_data for topology descriptions.
> 
> It's look like clk_hw_register_fixed_rate_parent_hw() is missing devm_
> version of this function. Is it ok to provide wrapper for
> __clk_hw_register_fixed_rate() in drivers/clk/clk-ep93xx.c ?

Yes, of course.

  reply	other threads:[~2024-07-10 19:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  9:36 [PATCH v10 00/38] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-06-17  9:36 ` [PATCH v10 03/38] clk: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin via B4 Relay
2024-07-08 22:18   ` Stephen Boyd
2024-07-09 15:30     ` Nikita Shubin
2024-07-10 10:34     ` Nikita Shubin
2024-07-10 19:55       ` Stephen Boyd [this message]
2024-07-10 19:56       ` Stephen Boyd
2024-06-17  9:36 ` [PATCH v10 06/38] dt-bindings: soc: Add " Nikita Shubin via B4 Relay
2024-06-17 10:58 ` [PATCH v10 00/38] ep93xx device tree conversion Andy Shevchenko
2024-06-18 16:20   ` Nikita Shubin
2024-06-27  8:29     ` Nikita Shubin
2024-07-05  9:21       ` Uwe Kleine-König
2024-07-08  7:34         ` Nikita Shubin
2024-07-10 12:31           ` Arnd Bergmann
2024-07-10 13:48             ` Nikita Shubin
2024-07-09 13:58         ` Rob Herring
2024-07-09 15:22           ` Uwe Kleine-König
2024-06-18 14:33 ` Jakub Kicinski
2024-06-18 16:33   ` Nikita Shubin
2024-06-18 18:08     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e10f0736ea87ed3f7cea4cac506fc24.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devnull+nikita.shubin.maquefel.me@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nikita.shubin@maquefel.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox