From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0283B774D for ; Mon, 29 Jun 2026 10:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729258; cv=none; b=CvmTlNWOlKpJlnEI4jw+255hWLoNI7//0wSNzv+vjaQ4kR+LqS/vwC8RbcMaZC1TNSL08jso8CZ4LClD10s3COs+tCCZSI+DGKvWV3/GjD7hfJzd2wIr61WtnryDYSKh03f/GW4A0sIWX/ujJzNLqRN/KNXpz95wmZGOfPC2HsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729258; c=relaxed/simple; bh=O7k+YKlCUgne8sQca2M+WCEzkz5Cqo5yJXcu0TM/sGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HUvwNBTCBK7A4NNCPL3W9V8tQxbGzwC3gP4LsKO2iI+8r0Ankgy7MY9VR2V9Fkh3X5ljLXeXMs4FepCbZGbKdwt91LPlyXXfqJdN6hdhr6LaNjvI2wKdCYt9tJnV72dXdtJQOf8bG9PREIuvro5iQz/HNnbMAWgTnirgpZWO6/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T9DISo9J; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h/qlPO38; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T9DISo9J"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h/qlPO38" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TASpgA2601074 for ; Mon, 29 Jun 2026 10:34:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= We8IfLXw172gbAFTQlf72mWB2mC4Z1ZwwihA6fagoqk=; b=T9DISo9J7j6psLNv 9DiNxp8vZleQfl3RhHDR60iFKwo45IIdPImrtT4bK9GpYfGsZ8u2EsybeHTD/GvE bHDoD5g8hHCwUDhu98o7J5vh86Ge45FPbJY0+p9vwJH7SuY+yOm3krw1O4ncgoJ4 /og6Gj6WJ3cLm2Mc7SBCyA7wqtDxX72X9iUZ8Qxs9jyjFywBID2v47xNfnO4TNd3 75hCcxyqd3mkICakMK/kpM28A3j2FgTctGuh+RMQjoeK+Mstkl5x6EfL6R0eVGvB T4vNXIJaWigJ86LWKBRUUKMejzVvXlfx1UeupSLAR+XYfhDZfh4dKNrTB1xMiItB ERyEyQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3nnw8cqg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 10:34:16 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-7376ea4bcccso46968137.2 for ; Mon, 29 Jun 2026 03:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782729256; x=1783334056; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=We8IfLXw172gbAFTQlf72mWB2mC4Z1ZwwihA6fagoqk=; b=h/qlPO38fVN7pZGU12/Z8pH6nbt8pWthZfyWeijTwt6cw3xywYJ1SahGCYr1aAuKpm BsJhlHCp/n4ZT38TW3P1XFocvuPvPzoU566cEzOuoKHMDjv6nMailUOG6hslIOpWafW1 RSqNxBqvCd56tRVbbg/00JvEMCBNnt64ebtmqvySoABCokMFzvHvUGnoCa2nRJG5tigg II15I8rTY3Zfm6SVDJ/aWypeoSH87YRKSP+A3XDwg6/z3sOLJ0sfPMAKL61ksFlL3K5o tnXq2ePWuGPczDv6kXIqu9Cx3QNwC2Vf/IJow5zPQeK1jEx26rbwfZ8ppxEPgIYvVemE iF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782729256; x=1783334056; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=We8IfLXw172gbAFTQlf72mWB2mC4Z1ZwwihA6fagoqk=; b=QEmHSjUKcTKugclNvuGqT7FNan+3rTw0e5qYnQZsIwuEK9QSk/t3iPomMsvJ2zsU2m 8pvkLipuzVAqEQTTHYFAUtAe93TbHysz+irTwF9okIL5dRhHcsO0VPnO5m2OG8jjNeFt 5T8RLVoCgdzIDRmTap7rPF6JQONJnl50dbFfFR6SaVh74KFzL1PafA38oaqM2pCnP7EB nUlO5Nj21/paux786W9arx/GkRXA0xfn0kMGP38udoR+Y3a/qQ2QD1GXYHR3nf8iOyDo kUt0n9YzpAAJuWQmivdadfbIxl4Q/jxbCQagvMx9pCdvzlC0TM6/c+wPJzx6xj8R3Vcn xb3g== X-Forwarded-Encrypted: i=1; AHgh+RoQNeXMOrv7SNN2zr0Ohfpq9qpLStaQ1YK5zeCXrdP1BLlyleo1169VRLjBAYLpqgtPiLnNKG34GlQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxuL/z8WkJ1d5jEGhjYN7rrRiV21XFg0BWZwHamQ08dNjydAS3o drhhLYAuRXZGj2yloedKdBepWC57GyjhBKItUV/LsTXbIstfpkQX8iyXge4S61wwW2od7F47a85 uJX5iehpaf5RloVeb5Nkyjh2ecUZhYGH+q5sjZJZZ5tzSWxF4efTMlhB3LE63Rv4= X-Gm-Gg: AfdE7clcMpC2uVnqwBiiFgQcUQdT6hZs7/hFGZS/DkCOS85PHvw0y9m4ZNldk/hyPBl JbEmIFScOJruel1V4S9uc5wX4jnAGhmmiuTTrFguH0ALCUwxxA6JA39v5C/QoW8VwcVgXBQKLP3 WXYCvB1gkxd4C6CZlYR1f2O2c94C06Luqv0Jow5xILZDtrexrijMUL6P9vSwODyEOYCwC6/mt1v kCL9gNuYErZPIFSnBDLt6HrS/JoXG1jHoXrMsIAxGaQqNAN70JCEj3bZH+iNYBF4kEIkfKMlDOP i6nueP1W/VyquUuW2IzCDu1EP5jv+cq0t8JVd+TkAil+GjWIZT+1UyIuqGJtrr6GCk445AUfHvx EZ5GIleuOLUvsntZ0Z+42evRm1BEqV3oHY+U= X-Received: by 2002:a05:6102:cd3:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-734366bedd7mr2311954137.5.1782729255772; Mon, 29 Jun 2026 03:34:15 -0700 (PDT) X-Received: by 2002:a05:6102:cd3:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-734366bedd7mr2311943137.5.1782729255151; Mon, 29 Jun 2026 03:34:15 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-697f3aeb509sm6698546a12.10.2026.06.29.03.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 03:34:14 -0700 (PDT) Message-ID: <8e4ea76e-f1c0-4dfd-8477-35e01ac0ba0d@oss.qualcomm.com> Date: Mon, 29 Jun 2026 12:34:10 +0200 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-7-c939c22ded0c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA4NSBTYWx0ZWRfX4n0BNI3fky7R RaKx+8V0tY5WQ7PiJHpcS5l9UqAP8O3/Lwt1nZQ2K4WMTumJ9WJLWqYZ6U9AUFmmAFmtVCE6fXd oOW/Q6818U1FyJ+v0qi2otDmV1ZszSQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA4NSBTYWx0ZWRfXwsKYcU19tkVP Aqw6+MUcO1sNxgCLFADAu1BvliuJoCKJpzyL4uZNedgWcIIWMUmkZ2wUlp8lxIhLlanCKB+5Kgy 6zVK6hDkDrclHKLlsq6yTA1670qtLNXwNDvzfngKFI+0YM47CvxXp7hAm3D1HCWdyhOJsgy9xsD SVdAmXJDhzCf6nM7LT6Eybu+qrd/plhUIRyDlHpcR1agH7yRz1IXVVRt+EN6WdqOB2/oo/VjoZK l8H30SbbHC7MO3HRhktVznrjnzmRYwY9xY8B1yZ2aY0lf/urqq4+pVGeBRPEVIsgQS5xcTd/cAH Srv07VPSoUN5t6Ls/9EuDqzgD4vpQLiiSH9YHNLuTMposLaE5W7gNWtG5LD50hA4H67yOCJH+Fr z4nKLsMt/CEwiR/47sld9LX6wS1byVSu919yiOXWVMnqF+8xgZZJpGR5NQPOe85Kzh6bxhfADXq q6EjXEzTFkzVFiR9Txw== X-Proofpoint-GUID: Q81-ZsXaScxiFYIkOOFTiID0aTchKAgn X-Authority-Analysis: v=2.4 cv=cefiaHDM c=1 sm=1 tr=0 ts=6a424a28 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=h4iy993FS52baA_BjO4A:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-ORIG-GUID: Q81-ZsXaScxiFYIkOOFTiID0aTchKAgn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290085 On 6/22/26 3:31 PM, Qiang Yu wrote: > On Mon, Jun 22, 2026 at 02:18:54PM +0200, Konrad Dybcio wrote: >> On 6/22/26 7:11 AM, Qiang Yu wrote: >>> Mahua has a different PCIe QREF topology from glymur. Override the TCSR >>> compatible to qcom,mahua-tcsr in mahua.dtsi, and wire up the required >>> LDO supplies for the PCIe clkref paths on the CRD board. >>> >>> Signed-off-by: Qiang Yu >>> --- >>> arch/arm64/boot/dts/qcom/mahua-crd.dts | 15 +++++++++++++++ >>> arch/arm64/boot/dts/qcom/mahua.dtsi | 4 ++++ >>> 2 files changed, 19 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/mahua-crd.dts b/arch/arm64/boot/dts/qcom/mahua-crd.dts >>> index 9c8244e892dd..8b42f5174b31 100644 >>> --- a/arch/arm64/boot/dts/qcom/mahua-crd.dts >>> +++ b/arch/arm64/boot/dts/qcom/mahua-crd.dts >>> @@ -19,3 +19,18 @@ / { >>> model = "Qualcomm Technologies, Inc. Mahua CRD"; >>> compatible = "qcom,mahua-crd", "qcom,mahua"; >>> }; >>> + >>> +&tcsr { >>> + vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrpt3-0p9-supply = <&vreg_l1f_e1_0p82>; >>> + vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p72>; >>> + vdda-qrefrpt5-0p9-supply = <&vreg_l2h_e0_0p72>; >>> + vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p83>; >>> + vdda-qrefrx3-0p9-supply = <&vreg_l2h_e0_0p72>; >>> + vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p82>; >>> + vdda-refgen3-0p9-supply = <&vreg_l1f_e1_0p82>; >>> + vdda-refgen3-1p2-supply = <&vreg_l4f_e1_1p08>; >> >> The supplies are correct, but QREF uses refgen4 on Mahua >> > > The instance is REFGEN4, but its regulator name is refgen3_xxx. Do you > think rename the supplies as vdda-refgen4-0p9-supply is better? Ah, I overlooked this. Maybe 4 could be better here, since the supplies that end up being assigned there match what we call refgen4 on Glymur. But there's no good answer, both options are terrible. Let's add a comment somewhere (in bindings?) describing this mess, perhaps like: # On Mahua, the REFGEN4 block is supplied through pads named REFGEN3 Konrad