Re: [PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

Conor Dooley
2025-02-18T16:50:34Z

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

On Tue, Feb 18, 2025 at 02:22:25PM +0100, AngeloGioacchino Del Regno wrote:
> Il 12/02/25 20:17, Conor Dooley ha scritto:
> > On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
> > > Add binding for the HDMI TX clock found in the VDO1 controller.
> > > While at it, also remove the unused CLK_VDO1_NR_CLK.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > > include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > index bd5cd100b796..0e87f61c90f4 100644
> > > --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > @@ -721,6 +721,6 @@
> > > #define CLK_VDO1_DPINTF 58
> > > #define CLK_VDO1_DISP_MONITOR_DPINTF 59
> > > #define CLK_VDO1_26M_SLOW 60
> > > -#define CLK_VDO1_NR_CLK 61
> > > +#define CLK_VDO1_DPI1_HDMI 61
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
> > fancy getting rid of that too.
>
> Thanks Conor, yeah I'll do that asap... one commit for each NR_CLK is a bit
> too much... I should just clean them all up :-)
>
> That requires a bit of work though, so it's not something that I can do in
> a few minutes; let's see if I can make it for this cycle, but no promises.

Yah, no worries. Was just pointing it out, don't need to let this
particular patch wait around for it by any means.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]