Linux clock framework development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	devicetree@vger.kernel.org
Cc: git@amd.com, linux-clk@vger.kernel.org, sboyd@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	michal.simek@xilinx.com
Subject: Re: [PATCH v1 2/2] drivers: clk: zynqmp: Add versal-net compatible string
Date: Thu, 30 Mar 2023 13:08:11 +0200	[thread overview]
Message-ID: <910df994-637e-07df-c53c-06a1c0d8d83e@linaro.org> (raw)
In-Reply-To: <20230330091309.16215-3-shubhrajyoti.datta@amd.com>

On 30/03/2023 11:13, Shubhrajyoti Datta wrote:
> From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
> 
> Add compatible string for versal-net.
> 
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
> 
>  drivers/clk/zynqmp/clkc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
> index 5636ff1ce552..1ea5fba20d91 100644
> --- a/drivers/clk/zynqmp/clkc.c
> +++ b/drivers/clk/zynqmp/clkc.c
> @@ -789,6 +789,7 @@ static int zynqmp_clock_probe(struct platform_device *pdev)
>  static const struct of_device_id zynqmp_clock_of_match[] = {
>  	{.compatible = "xlnx,zynqmp-clk"},
>  	{.compatible = "xlnx,versal-clk"},
> +	{.compatible = "xlnx,versal-net-clk"},

Why no driver data? Why do you create new driver matchings if devices
are compatible?

Best regards,
Krzysztof


  reply	other threads:[~2023-03-30 11:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  9:13 [PATCH v1 0/2] clk: zynqmp: Add versal-net compatible string Shubhrajyoti Datta
2023-03-30  9:13 ` [PATCH v1 1/2] dt-bindings: clock: versal: " Shubhrajyoti Datta
2023-03-30 11:07   ` Krzysztof Kozlowski
2023-03-30  9:13 ` [PATCH v1 2/2] drivers: clk: zynqmp: " Shubhrajyoti Datta
2023-03-30 11:08   ` Krzysztof Kozlowski [this message]
2023-03-30 12:00     ` Michal Simek
2023-03-30 13:32       ` Krzysztof Kozlowski
2023-03-30 13:49         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=910df994-637e-07df-c53c-06a1c0d8d83e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shubhrajyoti.datta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox