Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/02/2026 15:31, Anirudh Srinivasan wrote:
>>> +examples:
>>> +  - |
>>> +    clock-controller@a8000000 {
>>> +      compatible = "tenstorrent,atlantis-prcm-rcpu";
>>> +      reg = <0xa8000000 0x10000>;
>>> +      clocks = <&osc_24m>;
>>> +      #clock-cells = <1>;
>>> +      #reset-cells = <1>;
>>> +    };
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index dc731d37c8fe..0fc7bc6d0458 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -22534,8 +22534,10 @@ M:   Joel Stanley <jms@oss.tenstorrent.com>
>>>  L:   linux-riscv@lists.infradead.org
>>>  S:   Maintained
>>>  T:   git https://github.com/tenstorrent/linux.git
>>> +F:   Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
>>>  F:   Documentation/devicetree/bindings/riscv/tenstorrent.yaml
>>>  F:   arch/riscv/boot/dts/tenstorrent/
>>> +F:   include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>>>
>>>  RISC-V THEAD SoC SUPPORT
>>>  M:   Drew Fustini <fustini@kernel.org>
>>> diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>>> new file mode 100644
>>> index 000000000000..3820781127c3
>>> --- /dev/null
>>> +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>>
>> Still wrong name... Look at your compatible.
>>
>> Please read writing bindings doc in DT dir.
> 
> We will have multiple compatibles in the future (I dropped these in

Maybe you will, maybe not. But you do not have now.

> this version and I have mentioned this in the changelog in the cover
> letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document

Where did you mention it? I went TWICE through it.

> suggests picking a more generic name in this case, so isn't
> "tenstorrent,atlantis-prcm" okay for that?

No, because I don't want to keep guessing this. The docs clearly ask you
to post complete bindings, which now became less-complete, but fine.
Then the next rule asks you to use compatible as filename. You cannot
keep skipping the rules.

Best regards,
Krzysztof